You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com> on 2014/07/14 19:41:22 UTC
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
IMO, that's expected. The other commit emails contain the details that we want to review. No need to try to amend commit messages.
From: Mihai Chira <mi...@apache.org>>
Reply-To: "dev@flex.apache.org<ma...@flex.apache.org>" <de...@flex.apache.org>>
Date: Monday, July 14, 2014 6:32 AM
Cc: "commits@flex.apache.org<ma...@flex.apache.org>" <co...@flex.apache.org>>
Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch 'FLEX-34385' into develop
Hmm, I guess I should have edited the commit message to something more useful than "Merge branch 'FLEX-34385' into develop". How should I do that next time? Using commit --amend -m after merging my feature branch onto develop?
On 14 July 2014 14:27, <mi...@apache.org>> wrote:
Merge branch 'FLEX-34385' into develop
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
Branch: refs/heads/develop
Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
Parents: facd8ce 16d30c9
Author: Mihai C <mi...@apache.org>>
Authored: Mon Jul 14 14:17:40 2014 +0100
Committer: Mihai C <mi...@apache.org>>
Committed: Mon Jul 14 14:17:40 2014 +0100
----------------------------------------------------------------------
README | 4 ++--
env-template.properties | 2 +-
frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
3 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Mihai Chira <mi...@gmail.com>.
Good to know, thanks.
On 14 July 2014 18:41, Alex Harui <ah...@adobe.com> wrote:
> IMO, that's expected. The other commit emails contain the details that we
> want to review. No need to try to amend commit messages.
>
> From: Mihai Chira <mi...@apache.org>
> Reply-To: "dev@flex.apache.org" <de...@flex.apache.org>
> Date: Monday, July 14, 2014 6:32 AM
> Cc: "commits@flex.apache.org" <co...@flex.apache.org>
> Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge
> branch 'FLEX-34385' into develop
>
> Hmm, I guess I should have edited the commit message to something more
> useful than "Merge branch 'FLEX-34385' into develop". How should I do that
> next time? Using commit --amend -m after merging my feature branch onto
> develop?
>
>
> On 14 July 2014 14:27, <mi...@apache.org> wrote:
>>
>> Merge branch 'FLEX-34385' into develop
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
>>
>> Branch: refs/heads/develop
>> Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
>> Parents: facd8ce 16d30c9
>> Author: Mihai C <mi...@apache.org>
>> Authored: Mon Jul 14 14:17:40 2014 +0100
>> Committer: Mihai C <mi...@apache.org>
>> Committed: Mon Jul 14 14:17:40 2014 +0100
>>
>> ----------------------------------------------------------------------
>> README | 4 ++--
>> env-template.properties | 2 +-
>> frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
>> 3 files changed, 9 insertions(+), 3 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge branch
'FLEX-34385' into develop
Posted by Mihai Chira <mi...@gmail.com>.
Good to know, thanks.
On 14 July 2014 18:41, Alex Harui <ah...@adobe.com> wrote:
> IMO, that's expected. The other commit emails contain the details that we
> want to review. No need to try to amend commit messages.
>
> From: Mihai Chira <mi...@apache.org>
> Reply-To: "dev@flex.apache.org" <de...@flex.apache.org>
> Date: Monday, July 14, 2014 6:32 AM
> Cc: "commits@flex.apache.org" <co...@flex.apache.org>
> Subject: Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - Merge
> branch 'FLEX-34385' into develop
>
> Hmm, I guess I should have edited the commit message to something more
> useful than "Merge branch 'FLEX-34385' into develop". How should I do that
> next time? Using commit --amend -m after merging my feature branch onto
> develop?
>
>
> On 14 July 2014 14:27, <mi...@apache.org> wrote:
>>
>> Merge branch 'FLEX-34385' into develop
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/dc680bbf
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/dc680bbf
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/dc680bbf
>>
>> Branch: refs/heads/develop
>> Commit: dc680bbfb3e8e3fe7fb54c36456625ee8bb47027
>> Parents: facd8ce 16d30c9
>> Author: Mihai C <mi...@apache.org>
>> Authored: Mon Jul 14 14:17:40 2014 +0100
>> Committer: Mihai C <mi...@apache.org>
>> Committed: Mon Jul 14 14:17:40 2014 +0100
>>
>> ----------------------------------------------------------------------
>> README | 4 ++--
>> env-template.properties | 2 +-
>> frameworks/projects/framework/src/mx/core/UIComponent.as | 6 ++++++
>> 3 files changed, 9 insertions(+), 3 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>