You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by PurelyApplied <gi...@git.apache.org> on 2017/05/23 22:11:00 UTC

[GitHub] geode pull request #528: GEODE-1994, revisited: Removed guaranteed failures.

GitHub user PurelyApplied opened a pull request:

    https://github.com/apache/geode/pull/528

    GEODE-1994, revisited: Removed guaranteed failures.

    Removed two uses of ServerLauncher.Builder.setMemberName that are guaranteed to throw under the changes introduced by GEODE-1994.
    
    With the previous update to StringUtils, ServerLauncher.Builder.setMemberName throws when its input is blank.  These two uses are behind conditionals and only occur when the member name is blank, guaranteeing failure.  This results in the `status server` and `stop server` commands functioning only when `--name` is used, but failing with `--dir` and `--pid`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PurelyApplied/geode geode-1994.revised

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #528
    
----
commit 071780ed1aa2b12068f12291d032c30a930320ac
Author: Patrick Rhomberg <pr...@pivotal.io>
Date:   2017-05-23T22:07:11Z

    GEODE-1994, revisited: Removed two references to ServerLauncher.setMemberName that are guaranteed to throw under the changes introduced by GEODE-1994.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #528: GEODE-1994, revisited: Removed guaranteed failures.

Posted by PurelyApplied <gi...@git.apache.org>.

Github user PurelyApplied closed the pull request at:

    https://github.com/apache/geode/pull/528


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

Posted by jaredjstewart <gi...@git.apache.org>.

Github user jaredjstewart commented on the issue:

    https://github.com/apache/geode/pull/528
  
    Merged as dff937f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

Posted by PurelyApplied <gi...@git.apache.org>.

Github user PurelyApplied commented on the issue:

    https://github.com/apache/geode/pull/528
  
    Precheckin running...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

Posted by jaredjstewart <gi...@git.apache.org>.

Github user jaredjstewart commented on the issue:

    https://github.com/apache/geode/pull/528
  
    LGTM (pending green precheckin)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #528: GEODE-1994, revisited: Removed guaranteed failures.

Posted by PurelyApplied <gi...@git.apache.org>.

Github user PurelyApplied commented on the issue:

    https://github.com/apache/geode/pull/528
  
    Green across the board.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---