You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org> on 2010/11/04 13:01:45 UTC
[jira] Created: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Make form inside ModalWindow work without form outside ModalWindow
------------------------------------------------------------------
Key: WICKET-3146
URL: https://issues.apache.org/jira/browse/WICKET-3146
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Affects Versions: 1.4.10
Reporter: Frank Klein Koerkamp
Attachments: fix_form_in_modalwindow.diff
Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Klein Koerkamp updated WICKET-3146:
-----------------------------------------
Attachment: fix_form_in_modalwindow_with_support_ie6.diff
Added extra patch which also supports IE6. All other browsers will work well now including Chrome.
This makes using forms in modaldialog more clear and clean.
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Attachments: fix_form_in_modalwindow.diff, fix_form_in_modalwindow_with_support_ie6.diff
>
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier closed WICKET-3146.
------------------------------
Resolution: Duplicate
Assignee: Sven Meier
see Wicket-3404
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Assignee: Sven Meier
> Attachments: fix_form_in_modalwindow.diff, fix_form_in_modalwindow_with_support_ie6.diff
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Klein Koerkamp updated WICKET-3146:
-----------------------------------------
Attachment: fix_form_in_modalwindow.diff
Added patch
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Attachments: fix_form_in_modalwindow.diff
>
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932534#action_12932534 ]
Igor Vaynberg commented on WICKET-3146:
---------------------------------------
we can apply this patch when we no longer have to support IE6 in which case we do not have to do the DOM shuffling.
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Attachments: fix_form_in_modalwindow.diff
>
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Klein Koerkamp updated WICKET-3146:
-----------------------------------------
Issue Type: Bug (was: Improvement)
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Attachments: fix_form_in_modalwindow.diff
>
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932521#action_12932521 ]
Matej Knopp commented on WICKET-3146:
-------------------------------------
This will break if you put any form components into modal window and have the modal window inside a form.
If you use form in modal window you always have to put modal window in another form. Wicket will realize this and replace all form tags inside model window with div. The form tag in modal window markup has to be there because when the modal window is shown it is taken out of DOM hierarchy and put as toplevel element.
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Attachments: fix_form_in_modalwindow.diff
>
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3146) Make form inside ModalWindow work
without form outside ModalWindow
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-3146:
----------------------------------
Issue Type: Improvement (was: Bug)
> Make form inside ModalWindow work without form outside ModalWindow
> ------------------------------------------------------------------
>
> Key: WICKET-3146
> URL: https://issues.apache.org/jira/browse/WICKET-3146
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Affects Versions: 1.4.10
> Reporter: Frank Klein Koerkamp
> Attachments: fix_form_in_modalwindow.diff
>
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
>
> Currently is needed to have an Form outside an ModalWindow if you want to use a Form inside a ModalWindow.
> This is not needed when the form tag is not necessary in the ModalWindow generation javascript js.
> Will apply a patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.