You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "stefanlee (JIRA)" <ji...@apache.org> on 2018/07/25 11:12:00 UTC
[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555526#comment-16555526 ]
stefanlee commented on YARN-6307:
---------------------------------
thanks for this jira,[~yufeigu] [~templedf], I have a doubt that what is the difference between *fair share* in _FairSharePolicy#compare_ and *fair share* in _FairSharePolicy#computeShares_, I think the latter is related to *preempt*. there are incomprehensible.
> Refactor FairShareComparator#compare
> ------------------------------------
>
> Key: YARN-6307
> URL: https://issues.apache.org/jira/browse/YARN-6307
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Priority: Major
> Fix For: 2.9.0, 3.0.0-beta1
>
> Attachments: YARN-6307.001.patch, YARN-6307.002.patch, YARN-6307.003.patch
>
>
> The method does three things: compare the min share usage, compare fair share usage by checking weight ratio, break tied by submit time and name. They are mixed with each other which is not easy to read and maintenance, poor style. Additionally, there are potential performance issues, like no need to check weight ratio if minShare usage comparison already indicate the order. It is worth to improve considering huge amount invokings in scheduler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org