You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/09/23 12:15:26 UTC
[GitHub] tajo pull request: TAJO-1877: Adopt try-resource statement to Abst...
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/780
TAJO-1877: Adopt try-resource statement to AbstractDBStore
See https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html.
JDK 7 introduced try-resource statement for better resource allocation and deallocation.
I adopt this feature to AbstractDBStore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1877
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/780.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #780
----
commit b6836ae2dd2c47dbd2d59ad1245894f824d74b09
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-09-23T10:13:31Z
initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1877: Adopt try-resource statement to Abst...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/780#issuecomment-145474227
Sorry for late review. This patch looks good to me. Would you rebase it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1877: Adopt try-resource statement to Abst...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/780#issuecomment-145718594
@jihoonson Thanks for your reply. I just rebase this commit but some other problem is occured.
I'll create PR again after resolving all of the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1877: Adopt try-resource statement to Abst...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo closed the pull request at:
https://github.com/apache/tajo/pull/780
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---