You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ni...@apache.org on 2006/10/11 13:20:56 UTC
svn commit: r462772 -
/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Author: niallp
Date: Wed Oct 11 04:20:55 2006
New Revision: 462772
URL: http://svn.apache.org/viewvc?view=rev&rev=462772
Log:
Remove unused import of UnsupportedEncodingException and modify javadoc references to that class to use fully qualified name.
Modified:
jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Modified: jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java?view=diff&rev=462772&r1=462771&r2=462772
==============================================================================
--- jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java (original)
+++ jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java Wed Oct 11 04:20:55 2006
@@ -24,7 +24,6 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
-import java.io.UnsupportedEncodingException;
import java.net.URL;
import java.util.Collection;
import java.util.Date;
@@ -871,7 +870,7 @@
* @param encoding the encoding to use, null means platform default
* @return the file contents or null if read failed
* @throws IOException in case of an I/O error
- * @throws UnsupportedEncodingException if the encoding is not supported by the VM
+ * @throws java.io.UnsupportedEncodingException if the encoding is not supported by the VM
*/
public static String readFileToString(
File file, String encoding) throws IOException {
@@ -915,7 +914,7 @@
* @param encoding the encoding to use, null means platform default
* @return the list of Strings representing each line in the file
* @throws IOException in case of an I/O error
- * @throws UnsupportedEncodingException if the encoding is not supported by the VM
+ * @throws java.io.UnsupportedEncodingException if the encoding is not supported by the VM
* @since Commons IO 1.1
*/
public static List readLines(File file, String encoding) throws IOException {
@@ -989,7 +988,7 @@
* @param data the content to write to the file
* @param encoding the encoding to use, null means platform default
* @throws IOException in case of an I/O error
- * @throws UnsupportedEncodingException if the encoding is not supported by the VM
+ * @throws java.io.UnsupportedEncodingException if the encoding is not supported by the VM
*/
public static void writeStringToFile(File file,
String data, String encoding) throws IOException {
@@ -1032,7 +1031,7 @@
* @param encoding the encoding to use, null means platform default
* @param lines the lines to write, null entries produce blank lines
* @throws IOException in case of an I/O error
- * @throws UnsupportedEncodingException if the encoding is not supported by the VM
+ * @throws java.io.UnsupportedEncodingException if the encoding is not supported by the VM
* @since Commons IO 1.1
*/
public static void writeLines(File file, String encoding, Collection lines) throws IOException {
@@ -1053,7 +1052,7 @@
* @param lines the lines to write, null entries produce blank lines
* @param lineEnding the line separator to use, null is system default
* @throws IOException in case of an I/O error
- * @throws UnsupportedEncodingException if the encoding is not supported by the VM
+ * @throws java.io.UnsupportedEncodingException if the encoding is not supported by the VM
* @since Commons IO 1.1
*/
public static void writeLines(File file, String encoding, Collection lines, String lineEnding) throws IOException {
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r462772 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Posted by Rahul Akolkar <ra...@gmail.com>.
On 10/11/06, Stephen Colebourne <sc...@btopenworld.com> wrote:
> niallp@apache.org wrote:
> > Remove unused import of UnsupportedEncodingException and modify javadoc
> references to that class to use fully qualified name.
>
> I wouldn't exactly describe it as unused, as it was used by the javadoc.
> I guess our IDEs must differ because this wasn't showing as a problem
> for me.
>
<snip/>
True, eclipse-based tooling doesn't seem to flag it (by default), but
code checkers like checkstyle do (by default). I prefer to leave such
imports in, but its one of those things that can probably be chalked
off to being a matter of taste (and thereby, conformance to existing
style).
-Rahul
> Stephen
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r462772 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Maybe we (maven?) runs an older checkstyle, or maybe checkstyle is
wrong. I'm not fussed about reversion, just noting.
Stephen
Niall Pemberton wrote:
> On 10/11/06, Stephen Colebourne <sc...@btopenworld.com> wrote:
>
>> niallp@apache.org wrote:
>> > Remove unused import of UnsupportedEncodingException and modify javadoc
>> references to that class to use fully qualified name.
>>
>> I wouldn't exactly describe it as unused, as it was used by the javadoc.
>> I guess our IDEs must differ because this wasn't showing as a problem
>> for me.
>
>
> It was flagged on the checkstyle report - I guess a false positive - I
> can revert if you prefer.
>
> Niall
>
>
>> Stephen
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r462772 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Posted by Niall Pemberton <ni...@gmail.com>.
On 10/11/06, Stephen Colebourne <sc...@btopenworld.com> wrote:
> niallp@apache.org wrote:
> > Remove unused import of UnsupportedEncodingException and modify javadoc
> references to that class to use fully qualified name.
>
> I wouldn't exactly describe it as unused, as it was used by the javadoc.
> I guess our IDEs must differ because this wasn't showing as a problem
> for me.
It was flagged on the checkstyle report - I guess a false positive - I
can revert if you prefer.
Niall
> Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r462772 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/FileUtils.java
Posted by Stephen Colebourne <sc...@btopenworld.com>.
niallp@apache.org wrote:
> Remove unused import of UnsupportedEncodingException and modify javadoc
references to that class to use fully qualified name.
I wouldn't exactly describe it as unused, as it was used by the javadoc.
I guess our IDEs must differ because this wasn't showing as a problem
for me.
Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org