You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/20 06:37:19 UTC
[GitHub] [flink] spurthicriteo opened a new pull request #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
spurthicriteo opened a new pull request #11815:
URL: https://github.com/apache/flink/pull/11815
[[FLINK-14170]](https://issues.apache.org/jira/browse/FLINK-14170) introduced Hadoop version check to support older hadoop versions. However the check only included "hdfs" scheme but not "viewfs".
We are using StreamingFileSink to write data to our federated cluster and we are using cdh-2.6 hadoop version and we are hit with exception:
java.lang.UnsupportedOperationException: Recoverable writers on Hadoop are only supported for HDFS and for Hadoop version 2.7 or newer
## Brief change log
Removed the hadoop < 2.7 version check if scheme is viewfs in HadoopRecoverableWriter
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-616355624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160984484",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
}, {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
}, {
"hash" : "86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=395",
"triggerID" : "86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e",
"triggerType" : "PUSH"
}, {
"hash" : "86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162599323",
"triggerID" : "86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82b7e411419bbd8a1011bdc78e2a916dbc1256a7 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160984484) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750)
* 86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162599323) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=395)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-618375339
Thanks for looking into this.
The change good to me, but would be nice to "secure this" by a simple unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] spurthicriteo commented on pull request #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
spurthicriteo commented on pull request #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-620975706
@StephanEwen I tried setting up a viewfs mini cluster, but that seemed like an overkill. I added a simple testcase that mocks a filesystem with viewfs scheme.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #11815:
URL: https://github.com/apache/flink/pull/11815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-616342631
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 82b7e411419bbd8a1011bdc78e2a916dbc1256a7 (Mon Apr 20 06:39:13 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17253).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] spurthicriteo commented on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
spurthicriteo commented on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-617325795
@StephanEwen @kl0u Can you take a look at the change? Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-616355624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160984484",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
}, {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82b7e411419bbd8a1011bdc78e2a916dbc1256a7 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160984484) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-616355624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160984484",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
}, {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
}, {
"hash" : "86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82b7e411419bbd8a1011bdc78e2a916dbc1256a7 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160984484) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750)
* 86cbfdc47ff8e8b9fb5ef18044b81d94f5e9bd6e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-629133820
Thanks, I think this can work.
We are usually trying to avoid mockito, because it often leads to "too literal" tests. I see that it's not so easy to get a real viewFs running here.
Just out of curiosity: Have you tried to instantiate a viewFs over the HDFS minicluster?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-616355624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160984484",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
}, {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82b7e411419bbd8a1011bdc78e2a916dbc1256a7 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160984484) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7750)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-616355624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82b7e411419bbd8a1011bdc78e2a916dbc1256a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82b7e411419bbd8a1011bdc78e2a916dbc1256a7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on issue #11815: [FLINK-17253] Support viewfs for hadoop version < 2.7
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11815:
URL: https://github.com/apache/flink/pull/11815#issuecomment-618374966
@flinkbot approve-until architecture
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org