You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by GitBox <gi...@apache.org> on 2021/01/13 13:47:02 UTC
[GitHub] [velocity-site] martin-g opened a new pull request #1: Update docu about contributing patches/PRs
martin-g opened a new pull request #1:
URL: https://github.com/apache/velocity-site/pull/1
Fix few minor typos in README.txt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-763549171
Any comments on the proposed changes ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-763567932
So it still uses Apache CMS ? I thought this service is no more available and all projects have to use static site generators (like the mentioned `pelican`).
I'll see how this works!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g edited a comment on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769695261
Actually with this PR I will update the README with the new site building steps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g edited a comment on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769076194
It almost works!
1) I needed to use `trunk` branch. I am not sure whether this is correct. See my previous message above
2) The `get-involved.html` file is properly recreated now! But many other files are deleted, e.g.
```
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/ExternalWriterHttpServletResponse.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/JspUtils.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/JspWriterImpl.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityBodyContent.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityJspFragment.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityPageContext.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityToolsJspException.html
```
and many more. Maybe this is related to 1)
3) I am not sure how convenient the auto cloning to ../velocity-site-production is. I cannot push there, so I need to add my fork as a Git remote anyway. GitBox is not really useful for contributors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] arkanovicz commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
arkanovicz commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769053568
The dockerized site builder is functional.
The single shell script `velocity-site/builder/bin/builder.sh` should do all the work.
I think your setup was lacking some perl dependency (like xsltproc), and also the optional python Pygments package. Also, both versions of Markdown and Pygments have to be carefully chosen. All that is now taken care of in the dockerfile.
The script can be symlinked like in:
ln -s ../path/to/velocity-site/builder/bin/builder.sh ~/bin/velsite
Please let me know if it's functional for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] arkanovicz commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
arkanovicz commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-767603518
I have the same ubuntu, but with a python 2.7 markdown in `/usr/local/lib/python2.7/dist-packages/markdown/`, so I imagine it was installed by pip2.
The error you get with get-pip is [referenced on SO](https://stackoverflow.com/a/65866547/710286) : you need to use `https://bootstrap.pypa.io/2.7/get-pip.py` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g closed pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #1:
URL: https://github.com/apache/velocity-site/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769717987
Closing in favor of https://github.com/apache/velocity-site/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-759459067
I have the feeling that the information in the README.txt is not accurate anymore. There is no `tools/` folder and I was not able to generate `.html` files out of the `.mdtext` ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769069374
I am testing it now!
But you pushed to `trunk` branch while the README file says: `Note: the branch trnk is obsolete. Please use the master branch.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-768151773
@arkanovicz Thanks for the new url! The markdown module has been installed successfully for Python2 here! I also needed to install Perl's LWP::Simple (`cpan install LWP::Simple`).
But the generated HTML misses big chunks of the old one. See https://github.com/apache/velocity-site/pull/2 for more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-767572121
I am not sure I will be able to do it with Apache CMS :-/
Disclaimer: I am not very deep into Python!
I use Ubuntu 20.10 and there is no `pip2` package anymore, so I am not able to install the required `markdown` module/package.
Even https://bootstrap.pypa.io/get-pip.py does not work:
```
sudo python2 get-pip.py
Traceback (most recent call last):
File "get-pip.py", line 24226, in <module>
main()
File "get-pip.py", line 199, in main
bootstrap(tmpdir=tmpdir)
File "get-pip.py", line 82, in bootstrap
from pip._internal.cli.main import main as pip_entry_point
File "/tmp/tmpNh7KcV/pip.zip/pip/_internal/cli/main.py", line 60
sys.stderr.write(f"ERROR: {exc}")
^
SyntaxError: invalid syntax
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] arkanovicz commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
arkanovicz commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-768555706
It's not the python markdown daemon which is at fault, but the perl building script. The missing parts all correspond to dynamic sections in the [skeleton](https://github.com/apache/velocity-site/blob/trunk/cms/trunk/templates/skeleton.html).
I give the docker solution a try and let you know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769695261
Actually I will update the README with the new site building steps
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769695092
Everything works fine now!
Both this PR and https://github.com/apache/velocity-site/pull/2 are ready to be merged !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] martin-g commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769076194
It almost works!
1) I needed to use `trunk` branch. I am not sure whether this is correct. See my previous message above
2) The `get-involved.html` file is properly recreated now! But many other files are deleted, e.g.
```
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/ExternalWriterHttpServletResponse.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/JspUtils.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/JspWriterImpl.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityBodyContent.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityJspFragment.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityPageContext.html
D tools/devel/apidocs/org/apache/velocity/tools/view/jsp/jspimpl/class-use/VelocityToolsJspException.html
```
and many more. Maybe this is related to 1)
4) I am not sure how convenient the auto cloning to ../velocity-site-production is. I cannot push there, so I need to add my fork as a Git remote anyway. GitBox is not really useful for contributors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] arkanovicz commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
arkanovicz commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-769100000
Sorry for the branches error. Yes, you have to use master. The default branch on github is still trunk but the fix is ongoing.
The cloning of the production branch now uses github (on master!).
I hope the missing files were a consequence of (1), you'll tell me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] arkanovicz commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
arkanovicz commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-763565043
Hello.
The site building instructions are obsolete too, it's not using maven for the time being. The almost up-to-date informations (not yet taking out the migration to gitbox) are [here](http://velocity.apache.org/site-building.html).
The remaining looks ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[GitHub] [velocity-site] arkanovicz commented on pull request #1: Update docu about contributing patches/PRs
Posted by GitBox <gi...@apache.org>.
arkanovicz commented on pull request #1:
URL: https://github.com/apache/velocity-site/pull/1#issuecomment-763601546
It just uses a local checkout of the Apache CMS (without the CMS feature itself, of course). The plan is to move to something else (maybe [Pelican](https://github.com/getpelican/pelican), or why not an hosted J2EE webapp using [Velocity markdown templates](https://github.com/arkanovicz/velocity-markdown-directive)?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org