You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Rajneesh180 (via GitHub)" <gi...@apache.org> on 2026/02/28 04:19:51 UTC
[PR] CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic [cassandra]
Rajneesh180 opened a new pull request, #4645:
URL: https://github.com/apache/cassandra/pull/4645
The test `SetGetCompactionThroughputTest` fails on locales that use a comma (`,`) as a decimal separator (like `de_DE`). This PR makes the regex pattern locale-agnostic by using `[.,]` for decimals.
patch by Rajneesh180; reviewed by TBD for CASSANDRA-20178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic [cassandra]
Posted by "Rajneesh180 (via GitHub)" <gi...@apache.org>.
Rajneesh180 commented on PR #4645:
URL: https://github.com/apache/cassandra/pull/4645#issuecomment-4004326276
Hi @smiklosovic,
This is a one-line fix for CASSANDRA-20178 — the `SetGetCompactionThroughputTest` regex was doing a literal `.` match for the decimal separator, which fails on locales that use a comma (e.g. `de_DE`). Changed to `[.,]` to make it locale-agnostic.
No logic change, just a regex correction. Happy to adjust if there's a preferred pattern for locale handling in the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic [cassandra]
Posted by "Rajneesh180 (via GitHub)" <gi...@apache.org>.
Rajneesh180 closed pull request #4645: CASSANDRA-20178: Make SetGetCompactionThroughputTest locale-agnostic
URL: https://github.com/apache/cassandra/pull/4645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org