You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by PramodSSImmaneni <gi...@git.apache.org> on 2016/01/30 03:31:20 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-323
GitHub user PramodSSImmaneni opened a pull request:
https://github.com/apache/incubator-apex-core/pull/217
APEXCORE-323
Removing binary style archives and including the text contents instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PramodSSImmaneni/incubator-apex-core APEXCORE-323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 672b71d267fb1ef92fe676f69c445f0b903c095b
Author: Pramod Immaneni <pr...@datatorrent.com>
Date: 2016-01-30T02:29:49Z
Removing binary style archives and including the text contents instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-323
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/217#issuecomment-177260582
For us, these archives are opaque, the IDEs can stick into it whatever and I'm not in favor of extracting and checking the generated files into this source tree. I can see how potentially it is useful to diff what was changed by whom if the files are generated in a stable manner, but there is more work that needs to be done. For the user, the archive should be readily available.
My suggestion is to instead move the archive files into a space excluded from source archiving and rat check for this release. We can work on removing them from this tree later, potentially putting them into a separate branch and pointing the README to the github location, from where the user can download and import. I also think that they logically don't belong here, given they apply across versions and -core and -malhar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-323
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/217#issuecomment-177276694
Pramod, on the top level we should not create a .settings folder as that's where Eclipse actually puts ts settings. Can we do that just under intelij and netbeans and in a way so that the user can still see the README (need to update README also), like so:
```
$ tree -a misc
misc
└── ide-templates
├── eclipse
│ ├── apex-importorder.importorder
│ ├── apex-style.xml
│ └── README.md
├── intellij
│ ├── README.md
│ └── .settings
│ └── apex-style.jar
└── netbeans
├── README.md
└── .settings
└── apex-style.zip
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-323
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-323
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/217#issuecomment-177262505
Made the necessary changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-323
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/217#issuecomment-177342566
Will do the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-323
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/217#issuecomment-177261268
Agreed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---