[GitHub] jonpspri opened a new pull request #3467: Remove actionControllers tests from incubator-openwhisk repo

[GitBox <gi...@apache.org>]

jonpspri opened a new pull request #3467: Remove actionControllers tests from incubator-openwhisk repo
URL: https://github.com/apache/incubator-openwhisk/pull/3467
 
 
   ## Description
   
   When the various action controllers were spun out into their own repositories, they took their test suites with them.  However, the original source code for the test suites was left in `incubator-openwhisk` .  That was fine until we started compiling JAR files to support testing and leaving them in local maven.  Now the JAR files including the actionController tests can create classpath conflicts with the test being compiled from the individual runtimes, challenging the validity of the tests.
   
   This PR deletes the not-canonical versions of the tests from incubator-runtime.  There are certain utility classes that are duplicated among the runtime repos that should maybe eventually be factored further into an SDK, but for the moment simplicity in the test process is needed to ensure test validity.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [X] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [X] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services