You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/07/25 14:48:55 UTC
Review Request 68044: Added a test
`ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68044/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8811
https://issues.apache.org/jira/browse/MESOS-8811
Repository: mesos
Description
-------
Added a test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.
Diffs
-----
src/tests/containerizer/volume_image_isolator_tests.cpp b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce
Diff: https://reviews.apache.org/r/68044/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 68044: Added a test
`ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68044/#review206527
-----------------------------------------------------------
Bad patch!
Reviews applied: [68044, 68043, 68041, 68040, 67997, 67996, 66814, 66813, 66812, 66811, 66840]
Failed command: python support/apply-reviews.py -n -r 66811
Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-07-26 23:26:12 URL:https://reviews.apache.org/r/66811/diff/raw/ [2756/2756] -> "66811.patch" [1]
error: patch failed: 3rdparty/stout/CMakeLists.txt:30
error: 3rdparty/stout/CMakeLists.txt: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22963/console
- Mesos Reviewbot
On July 25, 2018, 2:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68044/
> -----------------------------------------------------------
>
> (Updated July 25, 2018, 2:48 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8811
> https://issues.apache.org/jira/browse/MESOS-8811
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_image_isolator_tests.cpp b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce
>
>
> Diff: https://reviews.apache.org/r/68044/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68044: Added a test
`ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68044/#review206446
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66811.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 66811`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1981/mesos-review-68044
Relevant logs:
- [apply-review-66811-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1981/mesos-review-68044/logs/apply-review-66811-stdout.log):
```
error: patch failed: 3rdparty/stout/CMakeLists.txt:30
error: 3rdparty/stout/CMakeLists.txt: patch does not apply
```
- Mesos Reviewbot Windows
On July 25, 2018, 2:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68044/
> -----------------------------------------------------------
>
> (Updated July 25, 2018, 2:48 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8811
> https://issues.apache.org/jira/browse/MESOS-8811
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_image_isolator_tests.cpp b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce
>
>
> Diff: https://reviews.apache.org/r/68044/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>