[jira] [Updated] (YARN-6450) TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest

["Jason Lowe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Lowe updated YARN-6450:
-----------------------------
    Fix Version/s: 2.8.2

I committed this to branch-2.8 and branch-2.8.2 as well.

> TestContainerManagerWithLCE requires override for each new test added to ContainerManagerTest
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-6450
>                 URL: https://issues.apache.org/jira/browse/YARN-6450
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>             Fix For: 2.9.0, 3.0.0-alpha4, 2.8.2
>
>         Attachments: YARN-6450.001.patch
>
>
> Every test in TestContainerManagerWithLCE looks like this:
> {code}
>   @Override
>   public void testSomething() throws Exception {
>     // Don't run the test if the binary is not available.
>     if (!shouldRunTest()) {
>       LOG.info("LCE binary path is not passed. Not running the test");
>       return;
>     }
>     LOG.info("Running something");
>     super.testSomething();
>   }
> {code}
> If  a new test is added to ContainerManagerTest then by default ContainerManagerTestWithLCE will fail when the LCE has not been configured.  This is an unnecessary maintenance burden.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org