[GitHub] [ratis] captainzmc commented on a change in pull request #615: RATIS-1541. Add SslContext to netty ChannelPipeline.

[GitBox <gi...@apache.org>]

captainzmc commented on a change in pull request #615:
URL: https://github.com/apache/ratis/pull/615#discussion_r820762631



##########
File path: ratis-grpc/src/main/java/org/apache/ratis/grpc/GrpcTlsConfig.java
##########
@@ -98,26 +97,25 @@ public GrpcTlsConfig(PrivateKey privateKey, X509Certificate certChain,
 
   public GrpcTlsConfig(File privateKeyFile, File certChainFile,

Review comment:
       This method is not used anywhere, can we delete it?

##########
File path: ratis-grpc/src/main/java/org/apache/ratis/grpc/client/GrpcClientProtocolClient.java
##########
@@ -38,7 +38,6 @@
 import org.apache.ratis.protocol.exceptions.LeaderNotReadyException;
 import org.apache.ratis.protocol.exceptions.TimeoutIOException;
 import org.apache.ratis.thirdparty.io.grpc.netty.GrpcSslContexts;

Review comment:
       This line can also be moved below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org