You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/08/24 13:50:56 UTC

[commons-csv] branch master updated: Use own API

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git


The following commit(s) were added to refs/heads/master by this push:
     new 545f0670 Use own API
545f0670 is described below

commit 545f0670ee4981282d079c90f09dacd0f72191d6
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Aug 24 09:50:52 2022 -0400

    Use own API
---
 src/main/java/org/apache/commons/csv/CSVRecord.java | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/apache/commons/csv/CSVRecord.java b/src/main/java/org/apache/commons/csv/CSVRecord.java
index 942a73c0..5524d9e8 100644
--- a/src/main/java/org/apache/commons/csv/CSVRecord.java
+++ b/src/main/java/org/apache/commons/csv/CSVRecord.java
@@ -18,12 +18,12 @@
 package org.apache.commons.csv;
 
 import java.io.Serializable;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Iterator;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 /**
@@ -271,9 +271,8 @@ public final class CSVRecord implements Serializable, Iterable<String> {
             return map;
         }
         getHeaderMapRaw().forEach((key, value) -> {
-            final int col = value;
-            if (col < values.length) {
-                map.put(key, values[col]);
+            if (value < values.length) {
+                map.put(key, values[value]);
             }
         });
         return map;
@@ -308,10 +307,7 @@ public final class CSVRecord implements Serializable, Iterable<String> {
      * @since 1.9.0
      */
     public List<String> toList() {
-        // Only allocate a single list of known size
-        final ArrayList<String> list = new ArrayList<>(values.length);
-        Stream.of(values).forEach(list::add);
-        return list;
+        return stream().collect(Collectors.toList());
     }
 
     /**