You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2024/10/31 08:36:00 UTC
[jira] [Updated] (OAK-11239) Remove usage of Guava newArrayList(vargargs) in test classes
[ https://issues.apache.org/jira/browse/OAK-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated OAK-11239:
---------------------------------
Description:
I'm separating this from the overall removal, because:
- there are several approaches ({{List.of}}, {{Arrays.asList}}, {{new Arraylist()}}), and for test cases they are easy to pick
- many of the uses are indeed in test cases because certain hardwired kinds of lists are tested (for instace, for test setup)
Approach:
- replace all of them by {{List.of}}
- change to {{Arrays.asList}} when failure due to missing support of `null`
- change to {{new ArrayList}} when failure due to immutability
This keeps the changes in tests as readable as possible,
was:
I'm separating this from the overall removal, because:
- there are several approaches (`List.of`, `Arrays.asList`, `new Arraylist()`), and for test cases they are easy to pick
- many of the uses are indeed in test cases because certain hardwired kinds of lists are tested
Approach:
- replace all of them by `List.of`
- change to `Arrays.asList` when failure due to missing support of `null`
- change to `new ArrayList` when failure due to immutability
This keeps the changes in tests as readable as possible,
> Remove usage of Guava newArrayList(vargargs) in test classes
> ------------------------------------------------------------
>
> Key: OAK-11239
> URL: https://issues.apache.org/jira/browse/OAK-11239
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: test
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
>
> I'm separating this from the overall removal, because:
> - there are several approaches ({{List.of}}, {{Arrays.asList}}, {{new Arraylist()}}), and for test cases they are easy to pick
> - many of the uses are indeed in test cases because certain hardwired kinds of lists are tested (for instace, for test setup)
> Approach:
> - replace all of them by {{List.of}}
> - change to {{Arrays.asList}} when failure due to missing support of `null`
> - change to {{new ArrayList}} when failure due to immutability
> This keeps the changes in tests as readable as possible,
--
This message was sent by Atlassian Jira
(v8.20.10#820010)