You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:37:32 UTC

[GitHub] [arrow] houqp commented on a change in pull request #7265: ARROW-8931: [Rust] add lexical sort support to arrow compute kernel

houqp commented on a change in pull request #7265:
URL: https://github.com/apache/arrow/pull/7265#discussion_r430064815



##########
File path: rust/arrow/src/compute/kernels/sort.rs
##########
@@ -668,4 +830,300 @@ mod tests {
             ],
         );
     }
+
+    #[test]
+    fn test_lex_sort_single_column() {
+        let input = vec![SortColumn {
+            values: Arc::new(PrimitiveArray::<Int64Type>::from(vec![
+                Some(17),

Review comment:
       @andygrove this PR currently doesn't support float array due to `Ord` trait constraints. I recommend adding float support as a follow up after we finalize the design in https://github.com/apache/arrow/pull/7193.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org