You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/05/18 02:29:55 UTC
[jira] Created: (QPID-1069) Patch to build trunk with Boost 1.35
Patch to build trunk with Boost 1.35
------------------------------------
Key: QPID-1069
URL: https://issues.apache.org/jira/browse/QPID-1069
Project: Qpid
Issue Type: Bug
Components: C++ Broker, C++ Client
Affects Versions: M3
Environment: RHEL, Boost 1.35
Reporter: Steve Huston
Priority: Trivial
Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
Index: Blob.h
===================================================================
--- Blob.h (revision 657445)
+++ Blob.h (working copy)
@@ -27,6 +27,7 @@
#include <boost/utility/typed_in_place_factory.hpp>
#include <boost/type_traits/is_base_and_derived.hpp>
#include <boost/utility/enable_if.hpp>
+#include <boost/version.hpp>
#include <new>
@@ -39,7 +40,8 @@
using boost::in_place;
using boost::typed_in_place_factory_base;
-/** 0-arg typed_in_place_factory, missing in boost. */
+/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
+#if (BOOST_VERSION < 103500)
template <class T>
struct typed_in_place_factory0 : public typed_in_place_factory_base {
typedef T value_type ;
@@ -49,6 +51,7 @@
/** 0-arg in_place<T>() function, missing from boost. */
template<class T>
typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
+#endif
template <class T, class R=void>
struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1069) Patch to build trunk with Boost 1.35
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1069:
-------------------------------
Attachment: QPID-1069.patch
Revised patch - the first one had a not-yet-existing #include.
> Patch to build trunk with Boost 1.35
> ------------------------------------
>
> Key: QPID-1069
> URL: https://issues.apache.org/jira/browse/QPID-1069
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: M3
> Environment: RHEL, Boost 1.35
> Reporter: Steve Huston
> Assignee: Andrew Stitcher
> Priority: Trivial
> Attachments: QPID-1069.patch
>
>
> Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
> Index: Blob.h
> ===================================================================
> --- Blob.h (revision 657445)
> +++ Blob.h (working copy)
> @@ -27,6 +27,7 @@
> #include <boost/utility/typed_in_place_factory.hpp>
> #include <boost/type_traits/is_base_and_derived.hpp>
> #include <boost/utility/enable_if.hpp>
> +#include <boost/version.hpp>
> #include <new>
> @@ -39,7 +40,8 @@
> using boost::in_place;
> using boost::typed_in_place_factory_base;
> -/** 0-arg typed_in_place_factory, missing in boost. */
> +/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
> +#if (BOOST_VERSION < 103500)
> template <class T>
> struct typed_in_place_factory0 : public typed_in_place_factory_base {
> typedef T value_type ;
> @@ -49,6 +51,7 @@
> /** 0-arg in_place<T>() function, missing from boost. */
> template<class T>
> typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
> +#endif
> template <class T, class R=void>
> struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1069) Patch to build trunk with Boost 1.35
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606928#action_12606928 ]
Andrew Stitcher commented on QPID-1069:
---------------------------------------
Applied the patch:
Built and tested trunk using Boost 1.34, _not 1.35_
So it's not been tested against 1.35, but causes no ill effects to 1.34
> Patch to build trunk with Boost 1.35
> ------------------------------------
>
> Key: QPID-1069
> URL: https://issues.apache.org/jira/browse/QPID-1069
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: M3
> Environment: RHEL, Boost 1.35
> Reporter: Steve Huston
> Assignee: Andrew Stitcher
> Priority: Trivial
> Attachments: QPID-1069.patch
>
>
> Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
> Index: Blob.h
> ===================================================================
> --- Blob.h (revision 657445)
> +++ Blob.h (working copy)
> @@ -27,6 +27,7 @@
> #include <boost/utility/typed_in_place_factory.hpp>
> #include <boost/type_traits/is_base_and_derived.hpp>
> #include <boost/utility/enable_if.hpp>
> +#include <boost/version.hpp>
> #include <new>
> @@ -39,7 +40,8 @@
> using boost::in_place;
> using boost::typed_in_place_factory_base;
> -/** 0-arg typed_in_place_factory, missing in boost. */
> +/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
> +#if (BOOST_VERSION < 103500)
> template <class T>
> struct typed_in_place_factory0 : public typed_in_place_factory_base {
> typedef T value_type ;
> @@ -49,6 +51,7 @@
> /** 0-arg in_place<T>() function, missing from boost. */
> template<class T>
> typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
> +#endif
> template <class T, class R=void>
> struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1069) Patch to build trunk with Boost 1.35
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1069:
-------------------------------
Attachment: QPID-1069.patch
Patch against trunk, svn revision 669663
> Patch to build trunk with Boost 1.35
> ------------------------------------
>
> Key: QPID-1069
> URL: https://issues.apache.org/jira/browse/QPID-1069
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: M3
> Environment: RHEL, Boost 1.35
> Reporter: Steve Huston
> Assignee: Andrew Stitcher
> Priority: Trivial
> Attachments: QPID-1069.patch
>
>
> Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
> Index: Blob.h
> ===================================================================
> --- Blob.h (revision 657445)
> +++ Blob.h (working copy)
> @@ -27,6 +27,7 @@
> #include <boost/utility/typed_in_place_factory.hpp>
> #include <boost/type_traits/is_base_and_derived.hpp>
> #include <boost/utility/enable_if.hpp>
> +#include <boost/version.hpp>
> #include <new>
> @@ -39,7 +40,8 @@
> using boost::in_place;
> using boost::typed_in_place_factory_base;
> -/** 0-arg typed_in_place_factory, missing in boost. */
> +/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
> +#if (BOOST_VERSION < 103500)
> template <class T>
> struct typed_in_place_factory0 : public typed_in_place_factory_base {
> typedef T value_type ;
> @@ -49,6 +51,7 @@
> /** 0-arg in_place<T>() function, missing from boost. */
> template<class T>
> typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
> +#endif
> template <class T, class R=void>
> struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1069) Patch to build trunk with Boost 1.35
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Stitcher resolved QPID-1069.
-----------------------------------
Resolution: Fixed
> Patch to build trunk with Boost 1.35
> ------------------------------------
>
> Key: QPID-1069
> URL: https://issues.apache.org/jira/browse/QPID-1069
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: M3
> Environment: RHEL, Boost 1.35
> Reporter: Steve Huston
> Assignee: Andrew Stitcher
> Priority: Trivial
> Attachments: QPID-1069.patch
>
>
> Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
> Index: Blob.h
> ===================================================================
> --- Blob.h (revision 657445)
> +++ Blob.h (working copy)
> @@ -27,6 +27,7 @@
> #include <boost/utility/typed_in_place_factory.hpp>
> #include <boost/type_traits/is_base_and_derived.hpp>
> #include <boost/utility/enable_if.hpp>
> +#include <boost/version.hpp>
> #include <new>
> @@ -39,7 +40,8 @@
> using boost::in_place;
> using boost::typed_in_place_factory_base;
> -/** 0-arg typed_in_place_factory, missing in boost. */
> +/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
> +#if (BOOST_VERSION < 103500)
> template <class T>
> struct typed_in_place_factory0 : public typed_in_place_factory_base {
> typedef T value_type ;
> @@ -49,6 +51,7 @@
> /** 0-arg in_place<T>() function, missing from boost. */
> template<class T>
> typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
> +#endif
> template <class T, class R=void>
> struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1069) Patch to build trunk with Boost 1.35
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1069:
-------------------------------
Attachment: (was: QPID-1069.patch)
> Patch to build trunk with Boost 1.35
> ------------------------------------
>
> Key: QPID-1069
> URL: https://issues.apache.org/jira/browse/QPID-1069
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: M3
> Environment: RHEL, Boost 1.35
> Reporter: Steve Huston
> Assignee: Andrew Stitcher
> Priority: Trivial
>
> Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
> Index: Blob.h
> ===================================================================
> --- Blob.h (revision 657445)
> +++ Blob.h (working copy)
> @@ -27,6 +27,7 @@
> #include <boost/utility/typed_in_place_factory.hpp>
> #include <boost/type_traits/is_base_and_derived.hpp>
> #include <boost/utility/enable_if.hpp>
> +#include <boost/version.hpp>
> #include <new>
> @@ -39,7 +40,8 @@
> using boost::in_place;
> using boost::typed_in_place_factory_base;
> -/** 0-arg typed_in_place_factory, missing in boost. */
> +/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
> +#if (BOOST_VERSION < 103500)
> template <class T>
> struct typed_in_place_factory0 : public typed_in_place_factory_base {
> typedef T value_type ;
> @@ -49,6 +51,7 @@
> /** 0-arg in_place<T>() function, missing from boost. */
> template<class T>
> typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
> +#endif
> template <class T, class R=void>
> struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1069) Patch to build trunk with Boost 1.35
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Stitcher reassigned QPID-1069:
-------------------------------------
Assignee: Andrew Stitcher
> Patch to build trunk with Boost 1.35
> ------------------------------------
>
> Key: QPID-1069
> URL: https://issues.apache.org/jira/browse/QPID-1069
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: M3
> Environment: RHEL, Boost 1.35
> Reporter: Steve Huston
> Assignee: Andrew Stitcher
> Priority: Trivial
>
> Trunk C++ code fails to build with Boost 1.35 - there's a missing Boost feature prior to 1.35 that is now available. This patch allows C++ trunk code to build with Boost 1.35.
> Index: Blob.h
> ===================================================================
> --- Blob.h (revision 657445)
> +++ Blob.h (working copy)
> @@ -27,6 +27,7 @@
> #include <boost/utility/typed_in_place_factory.hpp>
> #include <boost/type_traits/is_base_and_derived.hpp>
> #include <boost/utility/enable_if.hpp>
> +#include <boost/version.hpp>
> #include <new>
> @@ -39,7 +40,8 @@
> using boost::in_place;
> using boost::typed_in_place_factory_base;
> -/** 0-arg typed_in_place_factory, missing in boost. */
> +/** 0-arg typed_in_place_factory, missing in pre-1.35 boost. */
> +#if (BOOST_VERSION < 103500)
> template <class T>
> struct typed_in_place_factory0 : public typed_in_place_factory_base {
> typedef T value_type ;
> @@ -49,6 +51,7 @@
> /** 0-arg in_place<T>() function, missing from boost. */
> template<class T>
> typed_in_place_factory0<T> in_place() { return typed_in_place_factory0<T>(); }
> +#endif
> template <class T, class R=void>
> struct EnableInPlace
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.