You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2024/08/12 06:20:40 UTC

[PR] Publish 3.5.2 to docker registry [spark-docker]

yaooqinn opened a new pull request, #64:
URL: https://github.com/apache/spark-docker/pull/64

   
   
   ### What changes were proposed in this pull request?
   Publish 3.5.2 to docker registry
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you fix a bug, you can clarify why it is a bug.
   -->
   3.5.2 release step
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   no
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #64: Publish 3.5.2 to docker registry
URL: https://github.com/apache/spark-docker/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284459648

   https://hub.docker.com/r/apache/spark/tags
   
   I will pay more attention to the status of 3.5.2 tags these days


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284444470

   Hi @dongjoon-hyun this PR updates the apache/spark repo not the docker official.
   
   https://github.com/apache/spark-docker/actions/runs/10349065800 the action is successful but 3.5.2 tags are still missing. I guess it will take some time to get out？
   
   PR for update docker official repo is here - 
   https://github.com/docker-library/official-images/pull/17346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn merged PR #64:
URL: https://github.com/apache/spark-docker/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284452000

   I hope so, but I want to get a confirmation here because `Apache Spark 4.0.0-preview1` is also missing still. `2 months` (June 3rd ~ August 12th) is too long, isn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284457395

   I checked your PR content and realized that we didn't make a move for 4.0.0-preview1.
   
   Thank you so much for taking care of it, @yaooqinn .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2283459331

   Thank you @Yikun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284369008

   Thank you, @yaooqinn and @Yikun . 
   
   When is this going to be published? It seems that the last updated was 17 days ago.
   
   - https://hub.docker.com/_/spark/tags
   
   Also, cc @cloud-fan , is 4.0.0-preview published correctly? Although 4.0.0-preview was released on June 3rd, I cannot find any image in the above when I search with `preview`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284515691

   Hi @dongjoon-hyun 
   
   Can you check the 3.4 docker releases? The current tags are targeting 3.4.1
   
   https://github.com/docker-library/official-images/blob/master/library/spark#L84-L102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2285265302

   > > Hi @dongjoon-hyun
   > > Can you check the 3.4 docker releases? The current tags are targeting 3.4.1
   > > https://github.com/docker-library/official-images/blob/master/library/spark#L84-L102
   > 
   > The above link seems to be broken. I guess you fixed it already. 😄
   
   Hi @dongjoon-hyun 
   
   ![image](https://github.com/user-attachments/assets/fe569e71-06f0-4035-ae2b-0c7676e3ee76)
   
   There is no 3.4.3 Dockerfiles in this repo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2285144307

   > https://github.com/apache/spark-docker/actions/runs/10349065800 the action is successful but 3.5.2 tags are still missing. I guess it will take some time to get out？
   
   Looks like you trigger the [ghcr publish](https://github.com/apache/spark-docker/actions/runs/10349065800/job/28643535727#step:26:202) rather than apache publish:
   
   ![image](https://github.com/user-attachments/assets/8c022d0a-c28e-42cf-a267-9cc8e06596ee)
   Trigger apache image publish: https://github.com/apache/spark-docker/actions/runs/10361696726
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284573380

   > Hi @dongjoon-hyun
   > 
   > Can you check the 3.4 docker releases? The current tags are targeting 3.4.1
   > 
   > https://github.com/docker-library/official-images/blob/master/library/spark#L84-L102
   
   The above link seems to be broken. I guess you fixed it already. 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2284466922

   Oh, thank you for the link. Got it. My bad. So, we did for the old repository, `apache/spark`, only at that time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on code in PR #64:
URL: https://github.com/apache/spark-docker/pull/64#discussion_r1713272152


##########
versions.json:
##########
@@ -63,8 +124,7 @@
         "3.5.1-scala2.12-java11-python3-ubuntu",
         "3.5.1-python3",
         "3.5.1",
-        "python3",
-        "latest"
+        "python3"

Review Comment:
   Please remove spcial tag from 3.5.1: L98(python3-java17), L135 (r)、L127(python3)、L143(scala)
   
   Otherwise, will generate wrong version in [1] step
   
   [1] https://github.com/apache/spark-docker?tab=readme-ov-file#step-3-publish-spark-docker-official-images



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on code in PR #64:
URL: https://github.com/apache/spark-docker/pull/64#discussion_r1713272152


##########
versions.json:
##########
@@ -63,8 +124,7 @@
         "3.5.1-scala2.12-java11-python3-ubuntu",
         "3.5.1-python3",
         "3.5.1",
-        "python3",
-        "latest"
+        "python3"

Review Comment:
   Please also remove spcial tag from 3.5.1: L98(python3-java17), L135 (r)、L127(python3)、L143(scala)
   
   Otherwise, will generate wrong version in [1] step
   
   [1] https://github.com/apache/spark-docker?tab=readme-ov-file#step-3-publish-spark-docker-official-images



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] Publish 3.5.2 to docker registry [spark-docker]

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #64:
URL: https://github.com/apache/spark-docker/pull/64#issuecomment-2283209463

   cc @Yikun @dongjoon-hyun @HyukjinKwon @cloud-fan thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org