You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/16 09:09:46 UTC
[GitHub] [apisix] Hwting opened a new pull request #6630: docs: polishing authz-keycloak's docs
Hwting opened a new pull request #6630:
URL: https://github.com/apache/apisix/pull/6630
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
docs: polishing authz-keycloak's docs
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6630: docs: polishing authz-keycloak's docs
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #6630:
URL: https://github.com/apache/apisix/pull/6630#discussion_r828798029
##########
File path: docs/zh/latest/plugins/authz-keycloak.md
##########
@@ -81,6 +81,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
## 测试插件
+获取`{JWT Token}`
Review comment:
Should be a black space between "``" block and word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #6630: docs: polishing authz-keycloak's docs
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #6630:
URL: https://github.com/apache/apisix/pull/6630#discussion_r828092041
##########
File path: docs/zh/latest/plugins/authz-keycloak.md
##########
@@ -81,6 +81,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
## 测试插件
+获取`{JWT Token}`
+
+```shell
+curl \
+ -d "client_id=<YOUR_CLIENT_ID>" \
+ -d "username=<YOUR_USERNAMED>" \
+ -d "password=<YOUR_PASSWORD>" \
+ -d "grant_type=password" \
+ "http://localhost:8080/realms/${realm}/protocol/openid-connect/token"
Review comment:
Port is 8080?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zaunist commented on a change in pull request #6630: docs: polishing authz-keycloak's docs
Posted by GitBox <gi...@apache.org>.
zaunist commented on a change in pull request #6630:
URL: https://github.com/apache/apisix/pull/6630#discussion_r828796917
##########
File path: docs/zh/latest/plugins/authz-keycloak.md
##########
@@ -81,6 +81,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
## 测试插件
+获取`{JWT Token}`
Review comment:
```suggestion
获取 `{JWT Token}`
```
##########
File path: docs/zh/latest/plugins/authz-keycloak.md
##########
@@ -57,15 +57,15 @@ title: authz-keycloak
## 如何启用
-创建一个 `route` 对象，并在该 `route` 对象上启用 `authz-keycloak` 插件：
+创建一个 `route` 对象，并在该 `route` 对象上启用 `authz-keycloak` 插件,`${realm}`是`Keycloak`中的`realm`名称：
Review comment:
```suggestion
创建一个 `route` 对象，并在该 `route` 对象上启用 `authz-keycloak` 插件, `${realm}` 是 `Keycloak` 中的 `realm` 名称：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6630: docs: polishing authz-keycloak's docs
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6630:
URL: https://github.com/apache/apisix/pull/6630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Hwting commented on a change in pull request #6630: docs: polishing authz-keycloak's docs
Posted by GitBox <gi...@apache.org>.
Hwting commented on a change in pull request #6630:
URL: https://github.com/apache/apisix/pull/6630#discussion_r828120614
##########
File path: docs/zh/latest/plugins/authz-keycloak.md
##########
@@ -81,6 +81,19 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13
## 测试插件
+获取`{JWT Token}`
+
+```shell
+curl \
+ -d "client_id=<YOUR_CLIENT_ID>" \
+ -d "username=<YOUR_USERNAMED>" \
+ -d "password=<YOUR_PASSWORD>" \
+ -d "grant_type=password" \
+ "http://localhost:8080/realms/${realm}/protocol/openid-connect/token"
Review comment:
KEYCLOAK_HTTP_PORT: Keycloak HTTP port. Default: 8080，Or change to <YOUR_KEYCLOAK_HOST>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org