You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/06/06 00:36:43 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #20378: [fix](load) in strict mode, return error for insert if datatype convert fails

yiguolei commented on code in PR #20378:
URL: https://github.com/apache/doris/pull/20378#discussion_r1218742842


##########
be/src/http/action/stream_load.cpp:
##########
@@ -457,8 +457,10 @@ Status StreamLoadAction::_process_put(HttpRequest* http_req,
     if (!http_req->header(HTTP_STRICT_MODE).empty()) {
         if (iequal(http_req->header(HTTP_STRICT_MODE), "false")) {
             request.__set_strictMode(false);
+            ctx->strict_mode = false;
         } else if (iequal(http_req->header(HTTP_STRICT_MODE), "true")) {
             request.__set_strictMode(true);
+            ctx->strict_mode = true;

Review Comment:
   why set it? Or it never take affect in the past?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org