[GitHub] flink pull request #4801: [FLINK-7812] Log system resources metrics

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4801#discussion_r155503385
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/utils/SystemResourcesCounter.java ---
    @@ -0,0 +1,236 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.taskexecutor.utils;
    +
    +import org.apache.flink.api.common.time.Time;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import oshi.SystemInfo;
    +import oshi.hardware.CentralProcessor;
    +import oshi.hardware.CentralProcessor.TickType;
    +import oshi.hardware.HardwareAbstractionLayer;
    +import oshi.hardware.NetworkIF;
    +
    +import javax.annotation.concurrent.ThreadSafe;
    +
    +import java.util.concurrent.atomic.AtomicLongArray;
    +import java.util.concurrent.atomic.AtomicReferenceArray;
    +
    +import static org.apache.flink.util.Preconditions.checkState;
    +
    +/**
    + * Daemon thread logging system resources.
    + *
    + * To accurately and consistently report CPU and network usage we have to periodically probe
    + * CPU ticks and network sent/received bytes and then convert those values to CPU usage and
    + * send/receive byte rates.
    + */
    +@ThreadSafe
    --- End diff --
    
    A Thread is ThreadSafe? ;-)


---