You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/08/15 09:04:36 UTC
[GitHub] incubator-weex pull request #600: * [android] some bugfix for slider
GitHub user misakuo opened a pull request:
https://github.com/apache/incubator-weex/pull/600
* [android] some bugfix for slider
- add the property `keep-index` to control the init index
- fix auto scroll not trigger on first time
Testcase：
http://dotwe.org/vue/4b2245156baadcd4e55c92e045ead859
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/misakuo/incubator-weex android-bugfix-slider-keep-index
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/600.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #600
----
commit adaf9cfe9c2d79c3ed855a32490d59068e0ee8ee
Author: misakuo <mi...@apache.org>
Date: 2017-07-31T03:35:46Z
+ [android] return contentSize on getComponentRect when target component implemented ContentMeasurable @notdanger
commit eeff0201e43145cf1b03b08620a82ac2feab8d1c
Author: misakuo <mi...@apache.org>
Date: 2017-08-07T01:47:23Z
Merge remote-tracking branch 'upstream/0.16-dev' into 0.16-dev
commit a2e79af4c238a3a09bef1a11127dca2066e4b987
Author: misakuo <mi...@apache.org>
Date: 2017-08-09T08:18:52Z
Revert "Revert "+ [android] ignore set index when current index not zero @notdanger""
This reverts commit 947e8510b5f6aabd21ac6c6ada1ff3b0cd0d35eb.
commit 043bc9631801a6e74e6c4147ab057b6f17b5f27c
Author: misakuo <mi...@apache.org>
Date: 2017-08-10T09:03:43Z
Merge remote-tracking branch 'upstream/0.16-dev' into 0.16-dev
commit 1215e8f87ecc6624c68c6739f240a57e92fc2f0e
Author: misakuo <mi...@apache.org>
Date: 2017-08-11T03:25:13Z
Merge remote-tracking branch 'upstream/0.16-dev' into 0.16-dev
commit 7606dc7de79ecb82e589b224a736faccb6467308
Author: misakuo <mi...@apache.org>
Date: 2017-08-11T06:26:41Z
+ [android] add the 'keep-index' property for slider
commit 998707085d749b2dc0289650c29d665396276c27
Author: misakuo <mi...@apache.org>
Date: 2017-08-15T06:42:59Z
* [android] using independent Handler to handle auto scroll
commit be89af838d49cb730527de9b1fb717c9885da50c
Author: misakuo <mi...@apache.org>
Date: 2017-08-15T07:09:47Z
* [android] using independent Handler to handle auto scroll
commit fe0b41ec834e7d747dcab48732f34a5cec6d2e48
Author: misakuo <mi...@apache.org>
Date: 2017-08-15T07:32:38Z
* [android] using independent Handler to handle auto scroll
commit a62383e6f49af57d60fbcbd9ecbe1b17724b02f5
Author: misakuo <mi...@apache.org>
Date: 2017-08-15T08:12:04Z
* [android] using independent Handler to handle auto scroll
commit d336ad2aed639d1e95d65428788ef26466208fb7
Author: misakuo <mi...@apache.org>
Date: 2017-08-15T08:48:48Z
* [android] clean redundant
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #600: * [android] some bugfix for slider
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #600: * [android] some bugfix for slider
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/600
<!--
0 failure:
4 warning: No Changelog chan..., This PR modify SD..., This PR should up..., Potential BREAK C...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR modify SDK code without add/modify testcases.</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/view/WXCircleViewPager.java</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>According to the blame info, we recommended @luics , @sospartan to be the reviewers.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---