[GitHub] [kafka] satishd commented on a diff in pull request #13807: KAFKA-15040: trigger onLeadershipChange under KRaft mode

["satishd (via GitHub)" <gi...@apache.org>]

satishd commented on code in PR #13807:
URL: https://github.com/apache/kafka/pull/13807#discussion_r1219258912


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -3701,6 +3721,11 @@ class ReplicaManagerTest {
 
       assertEquals(None, replicaManager.replicaFetcherManager.getFetcher(topicPartition))
 
+      if (enableRemoteStorage) {

Review Comment:
   Do you also want to add similar coverage for both the below tests?
   
   ```
   testFetcherAreNotRestartedIfLeaderEpochIsNotBumpedWithKRaftPath
   testReplicasAreStoppedWhileInControlledShutdownWithKRaft
   ```



##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -3677,20 +3682,35 @@ class ReplicaManagerTest {
     assertEquals(None, replicaManager.getOrCreatePartition(bar1, emptyDelta, BAR_UUID))
   }
 
-  @Test
-  def testDeltaFromLeaderToFollower(): Unit = {
+  private def verifyRLMonLeadershipChange(leaderPartitions: util.Set[Partition], followerPartitions: util.Set[Partition]): Unit = {

Review Comment:
   nit: `verifyRLMonLeadershipChange` to `verifyRLMOnLeadershipChange`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org