You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/01/23 18:17:32 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #4200: HDDS-7820. Store container descriptor at start of tar archive

adoroszlai opened a new pull request, #4200:
URL: https://github.com/apache/ozone/pull/4200

   ## What changes were proposed in this pull request?
   
   `DownloadAndImportReplicator` extracts container descriptor (`container.yaml`) as a first step when importing the container.
   
   > A tar file isn't really indexed, and it doesn't have a "directory listing" section to list the files in it, it skips from one file header to the next seeking down the file. So if this file is always at the end, it must check all other file headers in the archive first.
   
   Currently the descriptor is stored at the end of the tarball, so the import process needs to read the entire tarball twice.
   
   This change moves the descriptor to the start of the archive.
   
   https://issues.apache.org/jira/browse/HDDS-7820
   
   ## How was this patch tested?
   
   Added an assertion about position of the descriptor.
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/3988198928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] sodonnel merged pull request #4200: HDDS-7820. Store container descriptor at start of tar archive

Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #4200:
URL: https://github.com/apache/ozone/pull/4200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org