You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/05 02:40:08 UTC
[GitHub] [apisix] zhendongcmss opened a new pull request #6013: fix the prometheus is inconsistent when using the same batch-processo…
zhendongcmss opened a new pull request #6013:
URL: https://github.com/apache/apisix/pull/6013
fix https://github.com/apache/apisix/issues/6011
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhendongcmss commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
zhendongcmss commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1007077292
> Can add a test case to reproduce this on 2.10?
ＮＰ．ａｄｄ ｔｅｓｔ ｃａｓｅ ｏｎ ｔｈｉｓ ＰＲ ｏｒ ｅｌｓｅｗｈｅｒｅ ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1006223863
ref: https://github.com/apache/apisix/issues/6011#issuecomment-1005334493
It looks like there's no problem on master so we don't need to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1006265296
> But, 2.10.x is TLS version, I think it is necessary.
We usually backport the bugfix from the master branch into the LTS version. if the bugfix is not found on master but exists on LTS verison, then it needs to be fixed. can you help to verify that this bug exists on the latest version of LTS:https://github.com/apache/apisix/tree/release/2.10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhendongcmss commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
zhendongcmss commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1006535936
> > But, 2.10.x is TLS version, I think it is necessary.
>
> We usually backport the bugfix from the master branch into the LTS version. if the bugfix is not found on master but exists on LTS verison, then it needs to be fixed. can you help to verify that this bug exists on the latest version of LTS:https://github.com/apache/apisix/tree/release/2.10?
I am sure that 2.10 has this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1007205210
> > Can add a test case to reproduce this on 2.10?
>
> ＮＰ．ａｄｄ ｔｅｓｔ ｃａｓｅ ｏｎ ｔｈｉｓ ＰＲ ｏｒ ｅｌｓｅｗｈｅｒｅ ？
you need to submit a new PR to release/2.10 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhendongcmss closed pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
zhendongcmss closed pull request #6013:
URL: https://github.com/apache/apisix/pull/6013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1006575164
Can add a test case to reproduce this on 2.10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhendongcmss commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
zhendongcmss commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1006240987
> ref: [#6011 (comment)](https://github.com/apache/apisix/issues/6011#issuecomment-1005334493)
>
> It looks like there's no problem on master so we don't need to fix it.
But, 2.10.x is TLS version, I think it is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1005854929
cc @spacewander what does patch-1 for? Do we need to fix the code on this branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1007205210
> > Can add a test case to reproduce this on 2.10?
>
> ＮＰ．ａｄｄ ｔｅｓｔ ｃａｓｅ ｏｎ ｔｈｉｓ ＰＲ ｏｒ ｅｌｓｅｗｈｅｒｅ ？
you need to submit a new PR to release/2.10 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhendongcmss commented on pull request #6013: fix: the prometheus lables are inconsistent when using the same batch-processor instance on multi plugins
Posted by GitBox <gi...@apache.org>.
zhendongcmss commented on pull request #6013:
URL: https://github.com/apache/apisix/pull/6013#issuecomment-1006214790
> I guess this PR is submitted to the wrong place?
to 2.10.1.1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org