You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Matthias Seidel <ma...@hamburg.de> on 2023/02/07 10:46:09 UTC
Pull Request 164
Hi all,
PR #164 [1] is a huge one.
It would be great if there was additional feedback...
Regards,
Matthias
[1] https://github.com/apache/openoffice/pull/164
Re: Pull Request 164
Posted by Matthias Seidel <ma...@hamburg.de>.
Hi Damjan,
Thanks!
Since AOO42X was split from trunk it should not be very different...
I will try to build on Windows now.
Regards,
Matthias
Am 12.02.23 um 20:02 schrieb Damjan Jovanovic:
> It's in AOO42X too now.
>
> Damjan
>
> On Sun, Feb 12, 2023 at 3:10 PM Damjan Jovanovic <da...@apache.org> wrote:
>
>> Hi
>>
>> I've now merged it.
>>
>> Should we also cherry-pick it into AOO42X? I am currently testing it there.
>>
>> Regards
>> Damjan
>>
>> On Sat, Feb 11, 2023 at 1:14 PM Matthias Seidel <
>> matthias.seidel@hamburg.de> wrote:
>>
>>> So at least 3 people are interested in this big enhancement...
>>>
>>> @Damjan: I would say, merge it! We need to move forward.
>>>
>>> Regards,
>>>
>>> Matthias
>>>
>>> Am 10.02.23 um 17:00 schrieb Matthias Seidel:
>>>> Hi Carl,
>>>>
>>>> Am 07.02.23 um 15:10 schrieb Carl Marcum:
>>>>> Hi All,
>>>>>
>>>>> On 2/7/23 5:46 AM, Matthias Seidel wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> PR #164 [1] is a huge one.
>>>>>>
>>>>>> It would be great if there was additional feedback...
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Matthias
>>>>>>
>>>>>> [1] https://github.com/apache/openoffice/pull/164
>>>>>>
>>>>>>
>>>>> A good test for this is to open this test file [1] in a browser and
>>>>> copy/paste into calc.
>>>>>
>>>>> You should get all 20,000 rows.
>>>> Did that and it works. Great!
>>>>
>>>> Regards,
>>>>
>>>> Matthias
>>>>
>>>>> [1]
>>> https://home.apache.org/~cmarcum/test-files/20000-row-html-table.html
>>>>> Best regards,
>>>>> Carl
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>>>>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>>>>
>>>
Re: Pull Request 164
Posted by Damjan Jovanovic <da...@apache.org>.
It's in AOO42X too now.
Damjan
On Sun, Feb 12, 2023 at 3:10 PM Damjan Jovanovic <da...@apache.org> wrote:
> Hi
>
> I've now merged it.
>
> Should we also cherry-pick it into AOO42X? I am currently testing it there.
>
> Regards
> Damjan
>
> On Sat, Feb 11, 2023 at 1:14 PM Matthias Seidel <
> matthias.seidel@hamburg.de> wrote:
>
>> So at least 3 people are interested in this big enhancement...
>>
>> @Damjan: I would say, merge it! We need to move forward.
>>
>> Regards,
>>
>> Matthias
>>
>> Am 10.02.23 um 17:00 schrieb Matthias Seidel:
>> > Hi Carl,
>> >
>> > Am 07.02.23 um 15:10 schrieb Carl Marcum:
>> >> Hi All,
>> >>
>> >> On 2/7/23 5:46 AM, Matthias Seidel wrote:
>> >>> Hi all,
>> >>>
>> >>> PR #164 [1] is a huge one.
>> >>>
>> >>> It would be great if there was additional feedback...
>> >>>
>> >>> Regards,
>> >>>
>> >>> Matthias
>> >>>
>> >>> [1] https://github.com/apache/openoffice/pull/164
>> >>>
>> >>>
>> >> A good test for this is to open this test file [1] in a browser and
>> >> copy/paste into calc.
>> >>
>> >> You should get all 20,000 rows.
>> > Did that and it works. Great!
>> >
>> > Regards,
>> >
>> > Matthias
>> >
>> >> [1]
>> https://home.apache.org/~cmarcum/test-files/20000-row-html-table.html
>> >>
>> >> Best regards,
>> >> Carl
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> >> For additional commands, e-mail: dev-help@openoffice.apache.org
>> >>
>>
>>
Re: Pull Request 164
Posted by Damjan Jovanovic <da...@apache.org>.
Hi
I've now merged it.
Should we also cherry-pick it into AOO42X? I am currently testing it there.
Regards
Damjan
On Sat, Feb 11, 2023 at 1:14 PM Matthias Seidel <ma...@hamburg.de>
wrote:
> So at least 3 people are interested in this big enhancement...
>
> @Damjan: I would say, merge it! We need to move forward.
>
> Regards,
>
> Matthias
>
> Am 10.02.23 um 17:00 schrieb Matthias Seidel:
> > Hi Carl,
> >
> > Am 07.02.23 um 15:10 schrieb Carl Marcum:
> >> Hi All,
> >>
> >> On 2/7/23 5:46 AM, Matthias Seidel wrote:
> >>> Hi all,
> >>>
> >>> PR #164 [1] is a huge one.
> >>>
> >>> It would be great if there was additional feedback...
> >>>
> >>> Regards,
> >>>
> >>> Matthias
> >>>
> >>> [1] https://github.com/apache/openoffice/pull/164
> >>>
> >>>
> >> A good test for this is to open this test file [1] in a browser and
> >> copy/paste into calc.
> >>
> >> You should get all 20,000 rows.
> > Did that and it works. Great!
> >
> > Regards,
> >
> > Matthias
> >
> >> [1]
> https://home.apache.org/~cmarcum/test-files/20000-row-html-table.html
> >>
> >> Best regards,
> >> Carl
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> >> For additional commands, e-mail: dev-help@openoffice.apache.org
> >>
>
>
Re: Pull Request 164
Posted by Matthias Seidel <ma...@hamburg.de>.
So at least 3 people are interested in this big enhancement...
@Damjan: I would say, merge it! We need to move forward.
Regards,
Matthias
Am 10.02.23 um 17:00 schrieb Matthias Seidel:
> Hi Carl,
>
> Am 07.02.23 um 15:10 schrieb Carl Marcum:
>> Hi All,
>>
>> On 2/7/23 5:46 AM, Matthias Seidel wrote:
>>> Hi all,
>>>
>>> PR #164 [1] is a huge one.
>>>
>>> It would be great if there was additional feedback...
>>>
>>> Regards,
>>>
>>> Matthias
>>>
>>> [1] https://github.com/apache/openoffice/pull/164
>>>
>>>
>> A good test for this is to open this test file [1] in a browser and
>> copy/paste into calc.
>>
>> You should get all 20,000 rows.
> Did that and it works. Great!
>
> Regards,
>
> Matthias
>
>> [1] https://home.apache.org/~cmarcum/test-files/20000-row-html-table.html
>>
>> Best regards,
>> Carl
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
Re: Pull Request 164
Posted by Matthias Seidel <ma...@hamburg.de>.
Hi Carl,
Am 07.02.23 um 15:10 schrieb Carl Marcum:
> Hi All,
>
> On 2/7/23 5:46 AM, Matthias Seidel wrote:
>> Hi all,
>>
>> PR #164 [1] is a huge one.
>>
>> It would be great if there was additional feedback...
>>
>> Regards,
>>
>> Matthias
>>
>> [1] https://github.com/apache/openoffice/pull/164
>>
>>
> A good test for this is to open this test file [1] in a browser and
> copy/paste into calc.
>
> You should get all 20,000 rows.
Did that and it works. Great!
Regards,
Matthias
>
> [1] https://home.apache.org/~cmarcum/test-files/20000-row-html-table.html
>
> Best regards,
> Carl
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
Re: Pull Request 164
Posted by Carl Marcum <cm...@apache.org>.
Hi All,
On 2/7/23 5:46 AM, Matthias Seidel wrote:
> Hi all,
>
> PR #164 [1] is a huge one.
>
> It would be great if there was additional feedback...
>
> Regards,
>
> Matthias
>
> [1] https://github.com/apache/openoffice/pull/164
>
>
A good test for this is to open this test file [1] in a browser and
copy/paste into calc.
You should get all 20,000 rows.
[1] https://home.apache.org/~cmarcum/test-files/20000-row-html-table.html
Best regards,
Carl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org