You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/27 08:13:25 UTC
[GitHub] [nifi] briansolo1985 opened a new pull request, #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
briansolo1985 opened a new pull request, #6587:
URL: https://github.com/apache/nifi/pull/6587
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10701](https://issues.apache.org/jira/browse/NIFI-10701)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] briansolo1985 commented on pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
briansolo1985 commented on PR #6587:
URL: https://github.com/apache/nifi/pull/6587#issuecomment-1293161259
As openjdk images are deprecated and discontinued I updated the base images to eclipse-temurin which can be considered as a successor of the openjdk line.
Also unified the image structures and documentation.
Removed the minifi arm64 definitions as eclipse-temurin images are multiarch ones, so can be built on arbitrary platforms.
Tested: run minifi and minifi-c2 intergration tests which rely on these images. Built the dockerhub images and run them locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kevdoran closed pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
kevdoran closed pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
URL: https://github.com/apache/nifi/pull/6587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kevdoran commented on a diff in pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
kevdoran commented on code in PR #6587:
URL: https://github.com/apache/nifi/pull/6587#discussion_r1023242521
##########
minifi/minifi-docker/dockerhub/Dockerfile:
##########
@@ -16,13 +16,13 @@
# under the License.
#
-FROM openjdk:8-jre-alpine
+FROM eclipse-temurin:8-jre
Review Comment:
I think I'm ok with this given it should not be being built frequently. I noticed the same about the `apt-get update && ...` command, but on the whole, I think the benefits are worth it. We can revisit if it becomes a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kevdoran commented on pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
kevdoran commented on PR #6587:
URL: https://github.com/apache/nifi/pull/6587#issuecomment-1308968191
Thanks for the contribution @briansolo1985 and for the help reviewing @bejancsaba @ferencerdei. I should be able to complete my review soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bejancsaba commented on a diff in pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
bejancsaba commented on code in PR #6587:
URL: https://github.com/apache/nifi/pull/6587#discussion_r1012720542
##########
minifi/minifi-docker/dockerhub/README.md:
##########
@@ -47,17 +46,17 @@ This can be accomplished through:
The following example shows the usage of two volumes to provide both a `config.yml` and a `bootstrap.conf` to the container instance. This makes use of configuration files on the host and maps them to be used by the MiNiFi instance. This is helpful in scenarios where a single image is used for a variety of configurations.
docker run -d \
- -v ~/minifi-conf/config.yml:/opt/minifi/minifi-0.5.0/conf/config.yml \
- -v ~/minifi-conf/bootstrap.conf:/opt/minifi/minifi-0.5.0/conf/bootstrap.conf \
- apache/nifi-minifi:0.5.0
Review Comment:
Quite a big jump in versions :)
##########
minifi/minifi-docker/dockerhub/Dockerfile:
##########
@@ -16,13 +16,13 @@
# under the License.
#
-FROM openjdk:8-jre-alpine
+FROM eclipse-temurin:8-jre
Review Comment:
I think it is good this way just wanted to double check whether it would make sense to pin the exact version as this way we get the latest and we can get "silent" java updates which could cause problems (at least I faced an issue on a previous project because of this). Again I think we are good and this is how it was earlier just wanted to double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] briansolo1985 commented on a diff in pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
briansolo1985 commented on code in PR #6587:
URL: https://github.com/apache/nifi/pull/6587#discussion_r1013785110
##########
minifi/minifi-docker/dockerhub/Dockerfile:
##########
@@ -16,13 +16,13 @@
# under the License.
#
-FROM openjdk:8-jre-alpine
+FROM eclipse-temurin:8-jre
Review Comment:
Yes I think it's beneficial to have the latest version for every build even though as you said there is a risk that a new Java version will cause issues. Would keep it as it is if no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] kevdoran commented on pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin
Posted by GitBox <gi...@apache.org>.
kevdoran commented on PR #6587:
URL: https://github.com/apache/nifi/pull/6587#issuecomment-1316123478
Merged in commit [709110da35f4f2cc91a916d0663742c594cba126](https://github.com/apache/nifi/commit/709110da35f4f2cc91a916d0663742c594cba126)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org