You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ian Duffy <ia...@ianduffy.ie> on 2013/06/26 12:40:57 UTC

Review Request 12104: Add a jetty:stop command to the cloud-client-ui

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12104/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.


Repository: cloudstack-git


Description
-------

Add a jetty:stop command to cloud-client-ui to allow stopping jetty when it is started within a CI environment


Diffs
-----

  client/pom.xml ffa5ec7 

Diff: https://reviews.apache.org/r/12104/diff/


Testing
-------

Compiled, ran mvn -pl :cloud-client-ui jetty:run waited for it to start up and then stopped it with mvn -pl :cloud-client-ui jetty:stop


Thanks,

Ian Duffy

Re: Review Request 12104: Add a jetty:stop command to the cloud-client-ui

Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12104/#review22404
-----------------------------------------------------------

Ship it!


Well done Ian,
this is now on master c214b47764be02d773d1f4ace8ea7c8600e371a7
please mark the review as submitted
thanks

- Sebastien Goasguen


On June 26, 2013, 10:40 a.m., Ian Duffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12104/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 10:40 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add a jetty:stop command to cloud-client-ui to allow stopping jetty when it is started within a CI environment
> 
> 
> Diffs
> -----
> 
>   client/pom.xml ffa5ec7 
> 
> Diff: https://reviews.apache.org/r/12104/diff/
> 
> 
> Testing
> -------
> 
> Compiled, ran mvn -pl :cloud-client-ui jetty:run waited for it to start up and then stopped it with mvn -pl :cloud-client-ui jetty:stop
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>