You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by laxmilal-menaria <gi...@git.apache.org> on 2016/08/28 11:43:46 UTC
[GitHub] metamodel pull request #127: Adding 2 more columns END and TABLE
GitHub user laxmilal-menaria opened a pull request:
https://github.com/apache/metamodel/pull/127
Adding 2 more columns END and TABLE
Added 2 More columns in Keywords List, I think we have lot of SQL keywords based on this documentation,
https://msdn.microsoft.com/en-us/library/ms189822.aspx
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laxmilal-menaria/metamodel patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
----
commit 217a79099f83810eabc59cf1c54d6b5b86f92d6b
Author: Laxmi Lal Menaria <lm...@chambal.com>
Date: 2016-08-28T11:41:28Z
Adding 2 more columns END and TABLE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #127: Adding 2 more columns END and TABLE
Posted by laxmilal-menaria <gi...@git.apache.org>.
Github user laxmilal-menaria commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/127#discussion_r76641546
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
@@ -58,6 +58,8 @@
KEYWORDS.add("DELETE");
KEYWORDS.add("AND");
KEYWORDS.add("OR");
+ KEYWORDS.add("END");
--- End diff --
Yes, we can add this too, but what happens if we add all keywords in one shot, is any performance degrade?
Adding columns one by one is not a good approach.
Thoughts?
Thanks,
Laxmilal Menaria
Sent from my iPhone
On Mon, Aug 29, 2016 at 10:07 PM +0530, "Kasper S�rensen" <no...@github.com> wrote:
In jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java:
> @@ -58,6 +58,8 @@
> KEYWORDS.add("DELETE");
> KEYWORDS.add("AND");
> KEYWORDS.add("OR");
> + KEYWORDS.add("END");
If we add "END" then we should probably also add "BEGIN" :)
\u2014
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #127: Adding 2 more columns END and TABLE
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/127#discussion_r76874584
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
@@ -58,6 +58,8 @@
KEYWORDS.add("DELETE");
KEYWORDS.add("AND");
KEYWORDS.add("OR");
+ KEYWORDS.add("END");
--- End diff --
I don't worry at all about the performance here because it is still a pretty small set and it happens just once. I worry a bit about maintaining this keyword list though, but that's a conversation that maybe goes beyond the scope of this little fix. I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #127: Adding 2 more columns END and TABLE
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #127: Adding 2 more columns END and TABLE
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/127#discussion_r76639933
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
@@ -58,6 +58,8 @@
KEYWORDS.add("DELETE");
KEYWORDS.add("AND");
KEYWORDS.add("OR");
+ KEYWORDS.add("END");
--- End diff --
If we add "END" then we should probably also add "BEGIN" :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---