You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/05/22 16:11:38 UTC
[GitHub] [nifi] zenfenan opened a new pull request #4290: NIFI-6701: Fix Future execution handling
zenfenan opened a new pull request #4290:
URL: https://github.com/apache/nifi/pull/4290
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Fixes bug NIFI-6701
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] zenfenan commented on a change in pull request #4290: NIFI-6701: Fix Future execution handling
Posted by GitBox <gi...@apache.org>.
zenfenan commented on a change in pull request #4290:
URL: https://github.com/apache/nifi/pull/4290#discussion_r431341413
##########
File path: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
##########
@@ -162,7 +162,7 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
ApiFuture<String> messageIdFuture = publisher.publish(message);
- while (messageIdFuture.isDone()) {
+ while (!messageIdFuture.isDone()) {
Review comment:
@markap14 That is true. I understand that `.get()` is a blocking call but when I was implementing this processor and tested this without this waiting while loop, I saw a few messages weren't getting published. I wasn't sure if it is something on the GCP side. I am not sure if it is still an issue and we can drop that piece of code since I don't have available GCP resources to try. Maybe @pvillard31 will have some idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4290: NIFI-6701: Fix Future execution handling
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4290:
URL: https://github.com/apache/nifi/pull/4290#discussion_r429583312
##########
File path: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/pubsub/PublishGCPubSub.java
##########
@@ -162,7 +162,7 @@ public void onTrigger(ProcessContext context, ProcessSession session) throws Pro
ApiFuture<String> messageIdFuture = publisher.publish(message);
- while (messageIdFuture.isDone()) {
+ while (!messageIdFuture.isDone()) {
Review comment:
@zenfenan is there a reason to have this loop at all? The next line calls `messageIdFuture.get()`, which is a blocking call. So we should just remove this entire loop, as it's adding up to a half-second delay for each FlowFile. Or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4290: NIFI-6701: Fix Future execution handling
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4290:
URL: https://github.com/apache/nifi/pull/4290#issuecomment-636100224
Thanks @pvillard31 . I have merged pr #4305. Looks like it upgrades from an "alpha" version of the SDK to a newer and more stable version. @zenfenan are you happy with that version? Are you ok closing this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4290: NIFI-6701: Fix Future execution handling
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #4290:
URL: https://github.com/apache/nifi/pull/4290#issuecomment-635900448
I submitted #4305 where I also updated the GCP dependencies and fixed a deprecated call. I've been running tests for a few hours and it worked as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] zenfenan closed pull request #4290: NIFI-6701: Fix Future execution handling
Posted by GitBox <gi...@apache.org>.
zenfenan closed pull request #4290:
URL: https://github.com/apache/nifi/pull/4290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] zenfenan commented on pull request #4290: NIFI-6701: Fix Future execution handling
Posted by GitBox <gi...@apache.org>.
zenfenan commented on pull request #4290:
URL: https://github.com/apache/nifi/pull/4290#issuecomment-636331117
@markap14 @pvillard31 Thanks for closing on this issue. It is good that we updated to a more latest version. I'm closing this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org