You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2020/10/04 11:49:06 UTC
[GitHub] [ant] twogee opened a new pull request #138: Update the optional dependencies
twogee opened a new pull request #138:
URL: https://github.com/apache/ant/pull/138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #138: Update the optional dependencies
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #138:
URL: https://github.com/apache/ant/pull/138#issuecomment-927281536
@twogee the switch to jakarta.mail is not backwards compatible. I don't think we can do it that way at all. Rather we'll need to introduce a new type of Mailer and an additional jar with different dependencies, I'm afraid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #138: Update the optional dependencies
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #138:
URL: https://github.com/apache/ant/pull/138#issuecomment-932727849
Thank you @twogee - do you think you could split the Jakarta Mailer support changes from the other changes?
The changes to `ClasspathUtils` seem to be completely unrelated to either and the chunk that removes string concatenation is completely unnecessary anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #138: Update the optional dependencies
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #138:
URL: https://github.com/apache/ant/pull/138#issuecomment-932738776
Thanks, @bodewig, and sorry about missing the extraneous changes.
I will open a new PR for changes re Jakarta Mail specifically.
The change to `ClasspathUtils` is related to an attempt to avoid nested `try` in `EmailTask#getMailerImplementation()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org