[jira] Commented: (SHINDIG-78) Add sample svn:props and svn:ignore sample files + script to set values in existent project files

["Santiago Gala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573845#action_12573845 ] 

Santiago Gala commented on SHINDIG-78:
--------------------------------------

I found accidentally that this patch is enabling svn:keywords, which has actually affected, in commit r628730, to

features/opensocial-samplecontainer/caja-compatible-jquery.js
php/js/jquery.js

I think svn:keywords is nowadays usually frowned up at the ASF, in fact those two files have had their original data swept by the change:


 

-------- features/opensocial-samplecontainer/caja-compatible-jquery.js --------
index 4b5be1c..97fd7ce 100644
@@ -6,8 +6,8 @@
  * Dual licensed under the MIT (MIT-LICENSE.txt)
  * and GPL (GPL-LICENSE.txt) licenses.
  *
- * $Date: 2007/09/28 $
- * $Rev: 3353 $
+ * $Date$
+ * $Rev$
  */
     
     // Map over jQuery in case of overwrite

------------------------------- php/js/jquery.js -------------------------------
index 89e182e..e94fd3b 100755
@@ -10,8 +10,8 @@ if (window.dojo) {
  * Dual licensed under the MIT (MIT-LICENSE.txt)
  * and GPL (GPL-LICENSE.txt) licenses.
  *
- * $Date: 2007-09-16 23:42:06 -0400 (Sun, 16 Sep 2007) $
- * $Rev: 3353 $
+ * $Date$
+ * $Rev$
  */
 
 // Map over jQuery in case of overwrite


Those two files have been imported from the outside, (  http://en.wikipedia.org/wiki/JQuery ,  http://jqueryjs.googlecode.com/files/jquery-1.2.1.js )
I wonder if this makes sense. I can remove svn:keywords from the script, while keeping the other properties, and commit it both to etc and "fix" the tree, but I wanted to issue a heads up first, just in case the svn:keywords addition is intended and not a remain from an outside script.

> Add sample svn:props and svn:ignore sample files + script to set values in existent project files
> -------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-78
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-78
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Luciano Resende
>            Assignee: Brian McCallister
>         Attachments: lresende.shindig-78.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.