You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "pbacsko (via GitHub)" <gi...@apache.org> on 2023/06/06 15:27:35 UTC
[GitHub] [yunikorn-core] pbacsko commented on a diff in pull request #538: [YUNIKORN-1607] Configuration processing should support limit hierarc…
pbacsko commented on code in PR #538:
URL: https://github.com/apache/yunikorn-core/pull/538#discussion_r1219862719
##########
pkg/common/configs/config_test.go:
##########
@@ -1721,3 +1722,418 @@ func TestGetConfigurationString(t *testing.T) {
})
}
}
+
+func prepareUserLimitsConfig(leafQueueMaxApps uint64, leafQueueMaxResource string) string {
+ data := `
+partitions:
+ - name: default
+ queues:
+ - name: root
+ maxapplications: 3000
+ limits:
+ - limit:
+ users:
+ - user1
+ maxresources: {memory: 10000, vcore: 10000}
+ maxapplications: 500
+ - limit:
+ users:
+ - user2
+ groups:
+ - prod
+ maxresources: {memory: 10000, vcore: 10000}
+ maxapplications: 300
+ queues:
+ - name: level1
+ maxapplications: 100
+ resources:
+ guaranteed:
+ {memory: 1000, vcore: 10}
+ max:
+ {memory: 10000, vcore: 1000}
+ limits:
+ - limit:
+ users:
+ - user1
+ maxapplications: 50
+ maxresources: {memory: 1000, vcore: 100}
+ queues:
+ - name: leaf
+ maxapplications: 100
+ resources:
+ guaranteed:
+ {memory: 1000, vcore: 10}
+ max:
+ {memory: 10000, vcore: 1000}
+ limits:
+ - limit:
+ users:
+ - user1
+ maxapplications: ` + strconv.Itoa(int(leafQueueMaxApps)) + `
+ maxresources: ` + leafQueueMaxResource + `
Review Comment:
Could you use placeholders like `%d`, `%s`, etc. then replace those with `Sprintf()`? That would make the embedded YAML more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org