You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "EricGao888 (via GitHub)" <gi...@apache.org> on 2023/07/25 12:11:51 UTC
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #14555: [Improvement][CI] deploy to k8s
EricGao888 commented on code in PR #14555:
URL: https://github.com/apache/dolphinscheduler/pull/14555#discussion_r1273427169
##########
.github/workflows/e2e-k8s.yml:
##########
@@ -0,0 +1,188 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+on:
+ pull_request:
+ push:
+ branches:
+ - dev
+
+name: E2E-K8S
+
+concurrency:
+ group: E2E-K8S-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+
+jobs:
+ paths-filter:
+ name: E2E-K8S-Path-Filter
+ runs-on: ubuntu-latest
+ outputs:
+ not-ignore: ${{ steps.filter.outputs.not-ignore }}
+ steps:
+ - uses: actions/checkout@v2
+ - uses: dorny/paths-filter@b2feaf19c27470162a626bd6fa8438ae5b263721
+ id: filter
+ with:
+ filters: |
+ not-ignore:
+ - '!(docs/**)'
+ e2e-k8s:
+ name: E2E-K8S-Execute
+ needs: paths-filter
+ if: ${{ (needs.paths-filter.outputs.not-ignore == 'true') || (github.event_name == 'push') }}
+ runs-on: ubuntu-latest
+ timeout-minutes: 20
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Build Image
+ run: |
+ ./mvnw -B clean package \
+ -Dmaven.test.skip \
+ -Dmaven.javadoc.skip \
+ -Dspotless.skip=true \
+ -Dmaven.checkstyle.skip \
+ -Dmaven.deploy.skip \
+ -Ddocker.push.skip=true \
+ -Pdocker,release -Ddocker.tag=ci \
+ -pl org.apache.dolphinscheduler:dolphinscheduler-alert-server \
Review Comment:
Just curious, why did you put `org.apache.dolphinscheduler:` only before `dolphinscheduler-alert-server`? Looks a little bit inconsistent to me.
##########
.github/workflows/e2e-k8s.yml:
##########
@@ -0,0 +1,188 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+on:
+ pull_request:
+ push:
+ branches:
+ - dev
+
+name: E2E-K8S
+
+concurrency:
+ group: E2E-K8S-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+
+jobs:
+ paths-filter:
+ name: E2E-K8S-Path-Filter
+ runs-on: ubuntu-latest
+ outputs:
+ not-ignore: ${{ steps.filter.outputs.not-ignore }}
+ steps:
+ - uses: actions/checkout@v2
+ - uses: dorny/paths-filter@b2feaf19c27470162a626bd6fa8438ae5b263721
+ id: filter
+ with:
+ filters: |
+ not-ignore:
+ - '!(docs/**)'
+ e2e-k8s:
+ name: E2E-K8S-Execute
+ needs: paths-filter
+ if: ${{ (needs.paths-filter.outputs.not-ignore == 'true') || (github.event_name == 'push') }}
+ runs-on: ubuntu-latest
+ timeout-minutes: 20
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Build Image
+ run: |
+ ./mvnw -B clean package \
+ -Dmaven.test.skip \
+ -Dmaven.javadoc.skip \
+ -Dspotless.skip=true \
+ -Dmaven.checkstyle.skip \
+ -Dmaven.deploy.skip \
+ -Ddocker.push.skip=true \
+ -Pdocker,release -Ddocker.tag=ci \
+ -pl org.apache.dolphinscheduler:dolphinscheduler-alert-server \
+ -pl dolphinscheduler-tools \
+ -pl dolphinscheduler-api \
+ -pl dolphinscheduler-master \
+ -pl dolphinscheduler-worker -am
+ - name: Create k8s Kind Cluster
+ run: |
+ # install kubectl
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
+ sudo chmod +x kubectl /usr/local/bin/kubectl
+ sudo mv kubectl /usr/local/bin/kubectl
+
+ # install kind
+ curl -LO https://github.com/kubernetes-sigs/kind/releases/download/v0.20.0/kind-linux-amd64
+ sudo chmod +x kind-linux-amd64
+ sudo mv kind-linux-amd64 /usr/local/bin/kind
+ kind version
+
+ # create kind cluster
+ kind_node_image="kindest/node:v1.23.17"
+ echo "Kubernetes version: ${kind_node_image}"
+ kind create cluster --name dolphinscheduler --image ${kind_node_image}
+ kubectl version --short
+ kubectl get all --all-namespaces
+ - name: Load images
+ run: |
+ components=("master" "worker" "api" "tools" "alert-server")
+ for component in "${components[@]}"; do
+ kind load docker-image apache/dolphinscheduler-${component}:ci --name dolphinscheduler
+ done
+ - name: Helm install dolphinscheduler
+ working-directory: ${{ github.workspace }}/deploy/kubernetes/dolphinscheduler
+ run: |
+ curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+ helm repo add bitnami https://charts.bitnami.com/bitnami
+ helm dependency update .
+ helm upgrade --install --create-namespace -n dolphinscheduler dolphinscheduler . -f - <<EOF
+ image:
+ registry: apache
+ tag: ci
+ conf:
+ common:
+ resource.azure.client.id: minioadmin
Review Comment:
Why set `resource.azure.xxxxxx` here? It seems in DS helm chart `values.yaml` there are not such configurations related to `azure`, do I miss anything? https://github.com/apache/dolphinscheduler/blob/dev/deploy/kubernetes/dolphinscheduler/values.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org