You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/30 11:40:33 UTC
[GitHub] [maven-dependency-plugin] elharo opened a new pull request #41:
remove debugging code
elharo opened a new pull request #41: remove debugging code
URL: https://github.com/apache/maven-dependency-plugin/pull/41
@michael-o
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] michael-o commented on issue #41: remove
debugging code
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #41: remove debugging code
URL: https://github.com/apache/maven-dependency-plugin/pull/41#issuecomment-605985557
I guess they are visible with `-X`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo commented on issue #41: remove
debugging code
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #41: remove debugging code
URL: https://github.com/apache/maven-dependency-plugin/pull/41#issuecomment-606064534
Haven't dived into the history of this file, but I suspect someone threw this in there when they were first implementing the model class or seeking some bug or performance issue, then never got around to taking it out. In general it's bad practice to have explicit `System.out` calls in tests. Ideally passing tests generate no output.
I noticed this because it was a use of a deprecated commons.lang field and figured I might as well delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-dependency-plugin] elharo merged pull request #41: remove
debugging code
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #41: remove debugging code
URL: https://github.com/apache/maven-dependency-plugin/pull/41
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services