You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/09/15 06:31:35 UTC
[PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
aminghadersohi opened a new pull request, #44287:
URL: https://github.com/apache/superset/pull/44287
### SUMMARY
Select `pinotdb[sqlalchemy]>=8.0.0,<10.0.0` instead of bare `pinotdb>=5.0.0,<10.0.0`. The first published version allowed by the old range is5.1.0; versions through7.0.0 declare SQLAlchemy>=1.4,<2 **in their optional `[sqlalchemy]` extra**. Version8.0.0 first declares SQLAlchemy>=2,<3. Selecting the extra lets the resolver enforce the dialect's support contract.
This is a declared-support floor, **not a claim that the old bare requirement causes an unconditional resolver conflict or that every old runtime operation fails**. Add optional regressions checking extra-conditioned dependency metadata and socket-free engine construction/parameter compilation for `pinot://`, `pinot+http://`, and `pinot+https://`. Document the requirement in metadata, its regenerated documentation field, and UPDATING.md. No dev lock change: Pinot is not part of the development install.
Independent [SC-121012](https://app.shortcut.com/preset/story/121012) slice of [SC-120252](https://app.shortcut.com/preset/story/120252). Shell #4935 already owns its9.1.2 upgrade; SC-121005/upstreampinot-dbapi#241 owns schema-qualified SQL and SC-121007 owns reflected DECIMAL/BYTES/multivalue behavior. Those runtime defects are explicitly not fixed here.
### TESTING INSTRUCTIONS
- `uv pip install --dry-run 'pinotdb[sqlalchemy]==7.0.0' 'sqlalchemy==2.0.52'` fails at the selected extra's `<2` constraint.
- Python3.11 / SQLAlchemy2.0.52 / greenlet3.5.5 / exactpinotdb8.0.0: `pytest -q tests/unit_tests/db_engine_specs/test_pinot.py` β **10 passed**. Independently rerun; final pinned-greenlet run also10.
- Bare7.0.0 old control underSQLAlchemy2: the three new tests reject the declared metadata at the intended version assertion (not an asserted runtime failure).
- Staged pre-commit: all applicable hooks pass, including mypy/Ruff/pylint/metadata validation. Generated docs field verified, unrelated drift excluded.
Evidence limits: the optional tests skip if Pinot is absent, including defaultCI. The inherited `dbapi()` warning on HTTPS is not a failure. Exact8.0.0 pins urllib3==2.6.0, so it does **not** coexist with the unchanged base lock's urllib3==2.7.0; this is not exact-lock/image qualification. The allowed range includes9.1.2, which pinsurllib3==2.7.0. No base pin is lowered. No live8 broker/controller, TLS/authentication, reflection, or production-image qualification is claimed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable.
### ADDITIONAL INFORMATION
- [x] Has associated issue: [SC-121012](https://app.shortcut.com/preset/story/121012)
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5687462778
### Exact-head CI checkpoint: `48931bcf0423997558f70e795d91da5c2dc92726`
**Not green / blocked.** All checks are terminal: 71 SUCCESS, 15 FAILURE, 10 conditional SKIPPED, 2 informational Netlify NEUTRAL. Seven of the 13 required checks fail; none is skipped. No cancelled/action-required/pending checks.
All 15 failed jobs on this new head were inspected individually: 12 actual execution jobs stop on Alembic MultipleHeads; 3 required aggregate jobs propagate their failures. The optional DockerHub login step is continue-on-error and concludes success; the Docker dev job's terminal failure is the migration startup. Separate repair #44288 is selected but remains unmerged and requires maintainer review. No migration workaround or unrelated repair was added here.
The range-wording feedback is fixed, 10 local Pinot tests and staged pre-commit passed, and hosted pre-commit / unit tests / all 20 testcontainers jobs passed. There are no GitHub review threads to resolve. Human review is still required. Worktree remains clean in zone-sqlalchemy-2, PR open/non-draft. Waiting for verified repair landing on single-head master before rebase and post-fix CI.
<details><summary>Full exact-head check rollup (98 checks)</summary>
| Workflow | Check | Result | Required |
|---|---|---|---|
| External status | [CodeQL](https://github.com/apache/superset/runs/104541051601) | SUCCESS | |
| External status | [Header rules - superset-docs-preview](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9a22afe18d80008b80184) | NEUTRAL | |
| External status | [Pages changed - superset-docs-preview](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9a22afe18d80008b80184) | NEUTRAL | |
| External status | [Redirect rules - superset-docs-preview](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9a22afe18d80008b80184) | SUCCESS | |
| External status | [codecov/patch](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [codecov/project](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [codecov/project/core-packages-ts](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [codecov/project/core-packages-tsx](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [netlify/superset-docs-preview/deploy-preview](https://deploy-preview-44287--superset-docs-preview.netlify.app) | SUCCESS | |
| External status | [zizmor](https://github.com/apache/superset/runs/104540707799) | SUCCESS | |
| Auto-approve Dependabot patch bumps | [Approve patch-level bump](https://github.com/apache/superset/actions/runs/35016292729/job/104540443128) | SKIPPED | |
| Build & publish docker images | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292716/job/104542661268) | SUCCESS | |
| Build & publish docker images | [changes](https://github.com/apache/superset/actions/runs/35016292716/job/104540441149) | SUCCESS | |
| Build & publish docker images | [docker-build (dev)](https://github.com/apache/superset/actions/runs/35016292716/job/104540667441) | FAILURE | |
| Build & publish docker images | [docker-build (lean)](https://github.com/apache/superset/actions/runs/35016292716/job/104540667681) | SUCCESS | |
| Build & publish docker images | [docker-build (superset)](https://github.com/apache/superset/actions/runs/35016292716/job/104540667453) | SUCCESS | |
| Build & publish docker images | [docker-compose-image-tag](https://github.com/apache/superset/actions/runs/35016292716/job/104540599285) | SKIPPED | |
| Build & publish docker images | [setup_matrix](https://github.com/apache/superset/actions/runs/35016292716/job/104540441070) | SUCCESS | |
| Build & publish docker images | [verify docker build PY_VER override](https://github.com/apache/superset/actions/runs/35016292716/job/104540440875) | SUCCESS | |
| Check OpenAPI spec drift | [check-openapi-spec-drift](https://github.com/apache/superset/actions/runs/35016292613/job/104540442158) | SUCCESS | |
| Check python dependencies | [check-python-deps](https://github.com/apache/superset/actions/runs/35016292714/job/104540440807) | SUCCESS | |
| CodeQL | [Analyze (javascript)](https://github.com/apache/superset/actions/runs/35016292599/job/104540605648) | SUCCESS | |
| CodeQL | [Analyze (python)](https://github.com/apache/superset/actions/runs/35016292599/job/104540605775) | SUCCESS | |
| CodeQL | [changes](https://github.com/apache/superset/actions/runs/35016292599/job/104540440329) | SUCCESS | |
| Dependency Review | [dependency-review](https://github.com/apache/superset/actions/runs/35016292795/job/104540441284) | SUCCESS | Yes |
| Dependency Review | [python-dependency-liccheck](https://github.com/apache/superset/actions/runs/35016292795/job/104540440909) | SUCCESS | |
| E2E | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292736/job/104541193738) | SUCCESS | |
| E2E | [changes](https://github.com/apache/superset/actions/runs/35016292736/job/104540440648) | SUCCESS | |
| E2E | [cypress-matrix (chrome)](https://github.com/apache/superset/actions/runs/35016292736/job/104540613877) | FAILURE | |
| E2E | [cypress-matrix-required](https://github.com/apache/superset/actions/runs/35016292736/job/104541077456) | FAILURE | Yes |
| E2E | [playwright-tests (chromium)](https://github.com/apache/superset/actions/runs/35016292736/job/104540613865) | FAILURE | |
| E2E | [playwright-tests (chromium, /app/prefix)](https://github.com/apache/superset/actions/runs/35016292736/job/104540613932) | FAILURE | |
| E2E | [playwright-tests-required](https://github.com/apache/superset/actions/runs/35016292736/job/104541162056) | FAILURE | Yes |
| Enforce single Alembic migration head | [enforce-single-migration-head](https://github.com/apache/superset/actions/runs/35016292743/job/104540440935) | SUCCESS | Yes |
| Frontend Build CI (unit tests, linting & sanity checks) | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292682/job/104540772743) | SUCCESS | |
| Frontend Build CI (unit tests, linting & sanity checks) | [bundle-size](https://github.com/apache/superset/actions/runs/35016292682/job/104540773690) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [frontend-build](https://github.com/apache/superset/actions/runs/35016292682/job/104540440608) | SUCCESS | Yes |
| Frontend Build CI (unit tests, linting & sanity checks) | [lint-frontend](https://github.com/apache/superset/actions/runs/35016292682/job/104540773892) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [report-coverage](https://github.com/apache/superset/actions/runs/35016292682/job/104540774558) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [sharded-jest-tests](https://github.com/apache/superset/actions/runs/35016292682/job/104540773969) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [test-storybook](https://github.com/apache/superset/actions/runs/35016292682/job/104540774190) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [validate-frontend](https://github.com/apache/superset/actions/runs/35016292682/job/104540772841) | SKIPPED | |
| Hold Label Check | [check-hold-label](https://github.com/apache/superset/actions/runs/35016292683/job/104540440108) | SUCCESS | |
| License Template Check | [License Check](https://github.com/apache/superset/actions/runs/35016292742/job/104540441631) | SUCCESS | |
| PR Lint | [lint-check](https://github.com/apache/superset/actions/runs/35016292649/job/104540440418) | SUCCESS | Yes |
| Playwright Experimental Tests | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292755/job/104541138649) | SUCCESS | |
| Playwright Experimental Tests | [changes](https://github.com/apache/superset/actions/runs/35016292755/job/104540441421) | SUCCESS | |
| Playwright Experimental Tests | [playwright-tests-experimental (chromium)](https://github.com/apache/superset/actions/runs/35016292755/job/104540616994) | FAILURE | |
| Playwright Experimental Tests | [playwright-tests-experimental (chromium, /app/prefix)](https://github.com/apache/superset/actions/runs/35016292755/job/104540616938) | FAILURE | |
| Pull Request Labeler | [labeler](https://github.com/apache/superset/actions/runs/35016287741/job/104540422622) | SUCCESS | |
| Python Presto/Hive | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292675/job/104541217625) | SUCCESS | |
| Python Presto/Hive | [changes](https://github.com/apache/superset/actions/runs/35016292675/job/104540440619) | SUCCESS | |
| Python Presto/Hive | [test-postgres-hive](https://github.com/apache/superset/actions/runs/35016292675/job/104540602368) | FAILURE | Yes |
| Python Presto/Hive | [test-postgres-presto](https://github.com/apache/superset/actions/runs/35016292675/job/104540602471) | FAILURE | Yes |
| Python-Integration | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292702/job/104541260535) | SUCCESS | |
| Python-Integration | [changes](https://github.com/apache/superset/actions/runs/35016292702/job/104540440923) | SUCCESS | |
| Python-Integration | [test-mysql](https://github.com/apache/superset/actions/runs/35016292702/job/104540612108) | FAILURE | Yes |
| Python-Integration | [test-postgres (current)](https://github.com/apache/superset/actions/runs/35016292702/job/104540611831) | FAILURE | |
| Python-Integration | [test-postgres-required](https://github.com/apache/superset/actions/runs/35016292702/job/104541068559) | FAILURE | Yes |
| Python-Integration | [test-sqlite](https://github.com/apache/superset/actions/runs/35016292702/job/104540611790) | FAILURE | Yes |
| Python-Unit | [changes](https://github.com/apache/superset/actions/runs/35016292720/job/104540441470) | SUCCESS | |
| Python-Unit | [event-file](https://github.com/apache/superset/actions/runs/35016292720/job/104540441143) | SUCCESS | |
| Python-Unit | [unit-tests (current)](https://github.com/apache/superset/actions/runs/35016292720/job/104540606720) | SUCCESS | |
| Python-Unit | [unit-tests-required](https://github.com/apache/superset/actions/runs/35016292720/job/104546910384) | SUCCESS | Yes |
| Superset App CLI tests | [test-load-examples](https://github.com/apache/superset/actions/runs/35016292817/job/104540441031) | FAILURE | |
| Superset Extensions CLI Package Tests | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292611/job/104540661219) | SUCCESS | |
| Superset Extensions CLI Package Tests | [test-superset-extensions-cli-package (current)](https://github.com/apache/superset/actions/runs/35016292611/job/104540440171) | SUCCESS | |
| Sync requirements for Python dependency PRs | [sync-python-dep-requirements](https://github.com/apache/superset/actions/runs/35016292673/job/104540442816) | SKIPPED | |
| Testcontainers | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292676/job/104541371980) | SUCCESS | |
| Testcontainers | [compute-matrix](https://github.com/apache/superset/actions/runs/35016292676/job/104540440958) | SUCCESS | |
| Testcontainers | [testcontainers (clickhouse, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479523) | SUCCESS | |
| Testcontainers | [testcontainers (cockroachdb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479531) | SUCCESS | |
| Testcontainers | [testcontainers (crate, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479517) | SUCCESS | |
| Testcontainers | [testcontainers (databend, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479525) | SUCCESS | |
| Testcontainers | [testcontainers (db2, 25)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479536) | SUCCESS | |
| Testcontainers | [testcontainers (elasticsearch, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479483) | SUCCESS | |
| Testcontainers | [testcontainers (firebird, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479643) | SUCCESS | |
| Testcontainers | [testcontainers (mariadb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479618) | SUCCESS | |
| Testcontainers | [testcontainers (monetdb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479704) | SUCCESS | |
| Testcontainers | [testcontainers (mongodb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479655) | SUCCESS | |
| Testcontainers | [testcontainers (mssql, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479576) | SUCCESS | |
| Testcontainers | [testcontainers (mysql, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479694) | SUCCESS | |
| Testcontainers | [testcontainers (oracle, 15)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479614) | SUCCESS | |
| Testcontainers | [testcontainers (postgres, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479671) | SUCCESS | |
| Testcontainers | [testcontainers (risingwave, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479690) | SUCCESS | |
| Testcontainers | [testcontainers (starrocks, 15)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479708) | SUCCESS | |
| Testcontainers | [testcontainers (timescaledb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479591) | SUCCESS | |
| Testcontainers | [testcontainers (trino, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479560) | SUCCESS | |
| Testcontainers | [testcontainers (ydb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479555) | SUCCESS | |
| Testcontainers | [testcontainers (yugabytedb, 10)](https://github.com/apache/superset/actions/runs/35016292676/job/104540479480) | SUCCESS | |
| Translations | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292723/job/104540990327) | SUCCESS | |
| Translations | [babel-extract](https://github.com/apache/superset/actions/runs/35016292723/job/104540440722) | SUCCESS | |
| Translations | [frontend-check-translations](https://github.com/apache/superset/actions/runs/35016292723/job/104540440840) | SUCCESS | |
| Validate All GitHub Actions | [validate-all-ghas](https://github.com/apache/superset/actions/runs/35016292721/job/104540440565) | SUCCESS | |
| pre-commit checks | [actions-timeline](https://github.com/apache/superset/actions/runs/35016292664/job/104542065013) | SUCCESS | |
| pre-commit checks | [pre-commit (current)](https://github.com/apache/superset/actions/runs/35016292664/job/104540440624) | SUCCESS | Yes |
| πͺ Superset Showtime | [Python Unit Test Results](https://github.com/apache/superset/runs/104547230419) | SUCCESS | |
| πͺ Superset Showtime | [πͺ Sync PR to desired state](https://github.com/apache/superset/actions/runs/35016287708/job/104540425101) | SKIPPED | |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5675846275
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | da5e0f6ab2fe65879fdc13af69b65663a6ec5f7f |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa8e64785e4d10008e0476d |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-44287--superset-docs-preview.netlify.app](https://deploy-preview-44287--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5wcJU-kHP2HTDQF0zLxL9PW9zmBdK5VQabAATHBWzC8PPHTG6QKkvolyZmzgjcx3FU4ncdz-SRrSklbErKT9LKS1JZbSH7wc) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44287--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5687454163
Final CI audit at head `48931bcf0423997558f70e795d91da5c2dc92726` β all checks terminal, none pending/cancelled/action-required: **66 pass, 12 skipped (conditional), 15 fail**. Workflow-level: 17 success, 3 skipped, 5 failure; no zero-job runs.
All 15 failures were inspected individually. 12 execution jobs (`test-sqlite`, `test-mysql`, `test-postgres (current)`, `test-postgres-hive`, `test-postgres-presto`, `test-load-examples`, `docker-build (dev)`, 4 playwright jobs, `cypress-matrix (chrome)`) stop at the same base-branch error:
```
ERROR [flask_migrate] Error: Multiple head revisions are present for given argument 'head'
```
The remaining 3 (`test-postgres-required`, `playwright-tests-required`, `cypress-matrix-required`) are aggregate gates propagating that result. **Zero failures are attributable to this PR's diff.** `unit-tests (current)`, `pre-commit (current)`, `docker-build (lean)`, `docker-build (superset)` and all 20 testcontainers jobs pass.
Independently recomputed from `origin/master` @ `a184395eca7c291d0b8b438f00690c633112f4d7`: 387 revisions, **2 heads** β `c7f53d184ea2` and `88a01c781622`. Master is broken for every PR, not just this one. Note that the `Enforce single Alembic migration head` check reports success here only because it short-circuits when a PR touches no `superset/migrations/` files; it is not evidence of a single head.
No rebase performed: this PR is `MERGEABLE` with no conflicts, and master still carries both heads, so a rebase cannot change any outcome.
**Coordination hazard worth flagging before either lands:** #44288 (`e2f3a1b9c640`) and #44283 (`f7b3a9c14e02`) *both* declare `down_revision = ("88a01c781622", "c7f53d184ea2")`. They merge the same two heads. If both land as authored, master ends up with two heads again and this exact blocker returns. Whichever merges second must be rebased to chain off the first as a single parent rather than re-merge the same pair.
**Exact human action required (maintainer-only):**
1. A Superset committer reviews and merges #44288 β a no-op merge revision joining exactly the two heads above; it is fully green (65 pass / 16 skipped / 0 fail).
2. Before merging #44283, rebase its `down_revision` onto whichever merge revision lands first.
3. Once master is single-head, this PR needs a re-run to clear the 15 red jobs, plus a committer approval (`reviewDecision: REVIEW_REQUIRED`).
Dependency claim re-verified directly against PyPI metadata: pinotdb `6.0.0`/`7.0.0` declare `sqlalchemy (>=1.4,<2)` under `extra == "sqlalchemy"`; `8.0.0` is the first release declaring `sqlalchemy (>=2.0,<3)`, unchanged through `9.1.2`. The `pinotdb[sqlalchemy]>=8.0.0,<10.0.0` floor and the matching UPDATING.md / metadata / docs wording are correct.
Known limitation, stated plainly: `test_dialect_supports_installed_sqlalchemy` uses `pytest.importorskip("pinotdb.sqlalchemy")` and `pinotdb` is not in `requirements/development.txt`, so that contract assertion skips rather than executes in `unit-tests (current)`. This follows the existing repo pattern (`tests/unit_tests/db_engine_specs/test_datastore.py`); adding the driver to dev requirements is deliberately out of scope here.
Nothing merged, nothing drafted, no migration workaround folded into this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5675927592
Final scope/CI checkpoint: independent review found no blocking implementation issues; canonical zone-pinned branch matches this published head. Hosted pre-commit and all 20 testcontainers jobs pass. Full unit suite remains pending; overall CI is not green. Actual migration-startup logs report Multiple head revisions on unchanged master (`c7f53d184ea2` and `88a01c781622`). Separate baseline repair is tracked as SC-121019, not folded into this driver PR. Full inventory/overlap and evidence boundaries: https://agor.sandbox.preset.zone/ui/kb/work-log/sqlalchemy2/sc120252-driver-floor-audit-2026-09-15.md . No formal human approval, live/exact-image qualification, or merge claimed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5688478187
### Final CI ownership result: `a56733f76173cf699133c5204c18dfd7a515332c`
**All applicable CI checks are terminal SUCCESS.** Verified 2026-09-15 21:40 UTC: **86 SUCCESS, 10 conditional SKIPPED, 2 informational Netlify NEUTRAL** (98 total). **13/13 required checks SUCCESS.** No failed, cancelled, action-required, pending or skipped-required checks; all check suites are terminal.
The separate baseline repair #44288 landed on master as 4c27cbd007efa298c2c1101b85a1ea158ed0502a. Verified exactly one Alembic head (e2f3a1b9c640), rebased without conflicts, and lease-pushed this exact head. All 15 formerly failed checks pass on this rebased head, including the CLI, E2E, integration and dev Docker jobs. No inherited failure was waived.
Addressed independent audit feedback by stating the complete pinotdb[sqlalchemy]>=8.0.0,<10.0.0 range in UPDATING.md, metadata and generated docs. Ten focused local tests and pre-commit across all five changed files passed after rebase. No GitHub review threads exist to resolve.
**Remaining blocker: human review/approval is required** (REVIEW_REQUIRED); the PR is open, non-draft and mergeable. No merge performed. Local and remote SHAs match; worktree is clean and remains in zone-sqlalchemy-2.
Conditional skips were inspected: six frontend subjobs have no frontend file changes; Dependabot approval and requirements-sync jobs do not apply to this human-authored fork PR; Showtime has no requested deployment; docker-compose-image-tag is a master-push-only job. Netlify Header rules and Pages changed are informational neutral results. None of these is a required check.
<details><summary>Full exact-head check rollup (98 checks)</summary>
| Workflow | Check | Result | Required |
|---|---|---|---|
| External status | [CodeQL](https://github.com/apache/superset/runs/104565202188) | SUCCESS | |
| External status | [Header rules - superset-docs-preview](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9b2c4fa3bef0008cd05fa) | NEUTRAL | |
| External status | [Pages changed - superset-docs-preview](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9b2c4fa3bef0008cd05fa) | NEUTRAL | |
| External status | [Redirect rules - superset-docs-preview](https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9b2c4fa3bef0008cd05fa) | SUCCESS | |
| External status | [codecov/patch](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [codecov/project](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [codecov/project/core-packages-ts](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [codecov/project/core-packages-tsx](https://app.codecov.io/gh/apache/superset/pull/44287) | SUCCESS | |
| External status | [netlify/superset-docs-preview/deploy-preview](https://deploy-preview-44287--superset-docs-preview.netlify.app) | SUCCESS | |
| External status | [zizmor](https://github.com/apache/superset/runs/104564764273) | SUCCESS | |
| Auto-approve Dependabot patch bumps | [Approve patch-level bump](https://github.com/apache/superset/actions/runs/35023417636/job/104564525420) | SKIPPED | |
| Build & publish docker images | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417588/job/104568314566) | SUCCESS | |
| Build & publish docker images | [changes](https://github.com/apache/superset/actions/runs/35023417588/job/104564523682) | SUCCESS | |
| Build & publish docker images | [docker-build (dev)](https://github.com/apache/superset/actions/runs/35023417588/job/104564704940) | SUCCESS | |
| Build & publish docker images | [docker-build (lean)](https://github.com/apache/superset/actions/runs/35023417588/job/104564704974) | SUCCESS | |
| Build & publish docker images | [docker-build (superset)](https://github.com/apache/superset/actions/runs/35023417588/job/104564704894) | SUCCESS | |
| Build & publish docker images | [docker-compose-image-tag](https://github.com/apache/superset/actions/runs/35023417588/job/104564706313) | SKIPPED | |
| Build & publish docker images | [setup_matrix](https://github.com/apache/superset/actions/runs/35023417588/job/104564524039) | SUCCESS | |
| Build & publish docker images | [verify docker build PY_VER override](https://github.com/apache/superset/actions/runs/35023417588/job/104564524115) | SUCCESS | |
| Check OpenAPI spec drift | [check-openapi-spec-drift](https://github.com/apache/superset/actions/runs/35023417611/job/104564524246) | SUCCESS | |
| Check python dependencies | [check-python-deps](https://github.com/apache/superset/actions/runs/35023417655/job/104564524502) | SUCCESS | |
| CodeQL | [Analyze (javascript)](https://github.com/apache/superset/actions/runs/35023417614/job/104564732761) | SUCCESS | |
| CodeQL | [Analyze (python)](https://github.com/apache/superset/actions/runs/35023417614/job/104564732832) | SUCCESS | |
| CodeQL | [changes](https://github.com/apache/superset/actions/runs/35023417614/job/104564523791) | SUCCESS | |
| Dependency Review | [dependency-review](https://github.com/apache/superset/actions/runs/35023417572/job/104564523965) | SUCCESS | Yes |
| Dependency Review | [python-dependency-liccheck](https://github.com/apache/superset/actions/runs/35023417572/job/104564524317) | SUCCESS | |
| E2E | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417582/job/104570665057) | SUCCESS | |
| E2E | [changes](https://github.com/apache/superset/actions/runs/35023417582/job/104564524539) | SUCCESS | |
| E2E | [cypress-matrix (chrome)](https://github.com/apache/superset/actions/runs/35023417582/job/104564710013) | SUCCESS | |
| E2E | [cypress-matrix-required](https://github.com/apache/superset/actions/runs/35023417582/job/104568511940) | SUCCESS | Yes |
| E2E | [playwright-tests (chromium)](https://github.com/apache/superset/actions/runs/35023417582/job/104564710043) | SUCCESS | |
| E2E | [playwright-tests (chromium, /app/prefix)](https://github.com/apache/superset/actions/runs/35023417582/job/104564710056) | SUCCESS | |
| E2E | [playwright-tests-required](https://github.com/apache/superset/actions/runs/35023417582/job/104570629480) | SUCCESS | Yes |
| Enforce single Alembic migration head | [enforce-single-migration-head](https://github.com/apache/superset/actions/runs/35023417589/job/104564523764) | SUCCESS | Yes |
| Frontend Build CI (unit tests, linting & sanity checks) | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417533/job/104564901314) | SUCCESS | |
| Frontend Build CI (unit tests, linting & sanity checks) | [bundle-size](https://github.com/apache/superset/actions/runs/35023417533/job/104564901632) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [frontend-build](https://github.com/apache/superset/actions/runs/35023417533/job/104564524188) | SUCCESS | Yes |
| Frontend Build CI (unit tests, linting & sanity checks) | [lint-frontend](https://github.com/apache/superset/actions/runs/35023417533/job/104564901344) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [report-coverage](https://github.com/apache/superset/actions/runs/35023417533/job/104564901976) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [sharded-jest-tests](https://github.com/apache/superset/actions/runs/35023417533/job/104564901869) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [test-storybook](https://github.com/apache/superset/actions/runs/35023417533/job/104564901530) | SKIPPED | |
| Frontend Build CI (unit tests, linting & sanity checks) | [validate-frontend](https://github.com/apache/superset/actions/runs/35023417533/job/104564901899) | SKIPPED | |
| Hold Label Check | [check-hold-label](https://github.com/apache/superset/actions/runs/35023417492/job/104564522942) | SUCCESS | |
| License Template Check | [License Check](https://github.com/apache/superset/actions/runs/35023417541/job/104564524758) | SUCCESS | |
| PR Lint | [lint-check](https://github.com/apache/superset/actions/runs/35023417612/job/104564524793) | SUCCESS | Yes |
| Playwright Experimental Tests | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417665/job/104568561324) | SUCCESS | |
| Playwright Experimental Tests | [changes](https://github.com/apache/superset/actions/runs/35023417665/job/104564524393) | SUCCESS | |
| Playwright Experimental Tests | [playwright-tests-experimental (chromium)](https://github.com/apache/superset/actions/runs/35023417665/job/104564710406) | SUCCESS | |
| Playwright Experimental Tests | [playwright-tests-experimental (chromium, /app/prefix)](https://github.com/apache/superset/actions/runs/35023417665/job/104564710272) | SUCCESS | |
| Pull Request Labeler | [Python Unit Test Results](https://github.com/apache/superset/runs/104570603420) | SUCCESS | |
| Pull Request Labeler | [labeler](https://github.com/apache/superset/actions/runs/35023415689/job/104564517686) | SUCCESS | |
| Python Presto/Hive | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417620/job/104566121787) | SUCCESS | |
| Python Presto/Hive | [changes](https://github.com/apache/superset/actions/runs/35023417620/job/104564524007) | SUCCESS | |
| Python Presto/Hive | [test-postgres-hive](https://github.com/apache/superset/actions/runs/35023417620/job/104564712973) | SUCCESS | Yes |
| Python Presto/Hive | [test-postgres-presto](https://github.com/apache/superset/actions/runs/35023417620/job/104564712934) | SUCCESS | Yes |
| Python-Integration | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417536/job/104574187358) | SUCCESS | |
| Python-Integration | [changes](https://github.com/apache/superset/actions/runs/35023417536/job/104564524071) | SUCCESS | |
| Python-Integration | [test-mysql](https://github.com/apache/superset/actions/runs/35023417536/job/104564716035) | SUCCESS | Yes |
| Python-Integration | [test-postgres (current)](https://github.com/apache/superset/actions/runs/35023417536/job/104564716037) | SUCCESS | |
| Python-Integration | [test-postgres-required](https://github.com/apache/superset/actions/runs/35023417536/job/104574158804) | SUCCESS | Yes |
| Python-Integration | [test-sqlite](https://github.com/apache/superset/actions/runs/35023417536/job/104564716143) | SUCCESS | Yes |
| Python-Unit | [changes](https://github.com/apache/superset/actions/runs/35023417545/job/104564524851) | SUCCESS | |
| Python-Unit | [event-file](https://github.com/apache/superset/actions/runs/35023417545/job/104564524465) | SUCCESS | |
| Python-Unit | [unit-tests (current)](https://github.com/apache/superset/actions/runs/35023417545/job/104564707448) | SUCCESS | |
| Python-Unit | [unit-tests-required](https://github.com/apache/superset/actions/runs/35023417545/job/104570334534) | SUCCESS | Yes |
| Superset App CLI tests | [test-load-examples](https://github.com/apache/superset/actions/runs/35023417550/job/104564524031) | SUCCESS | |
| Superset Extensions CLI Package Tests | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417674/job/104564746427) | SUCCESS | |
| Superset Extensions CLI Package Tests | [test-superset-extensions-cli-package (current)](https://github.com/apache/superset/actions/runs/35023417674/job/104564524879) | SUCCESS | |
| Sync requirements for Python dependency PRs | [sync-python-dep-requirements](https://github.com/apache/superset/actions/runs/35023417637/job/104564526631) | SKIPPED | |
| Testcontainers | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417658/job/104565526801) | SUCCESS | |
| Testcontainers | [compute-matrix](https://github.com/apache/superset/actions/runs/35023417658/job/104564524045) | SUCCESS | |
| Testcontainers | [testcontainers (clickhouse, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555635) | SUCCESS | |
| Testcontainers | [testcontainers (cockroachdb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555813) | SUCCESS | |
| Testcontainers | [testcontainers (crate, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555743) | SUCCESS | |
| Testcontainers | [testcontainers (databend, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555627) | SUCCESS | |
| Testcontainers | [testcontainers (db2, 25)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555785) | SUCCESS | |
| Testcontainers | [testcontainers (elasticsearch, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555639) | SUCCESS | |
| Testcontainers | [testcontainers (firebird, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555875) | SUCCESS | |
| Testcontainers | [testcontainers (mariadb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564556113) | SUCCESS | |
| Testcontainers | [testcontainers (monetdb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555671) | SUCCESS | |
| Testcontainers | [testcontainers (mongodb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555735) | SUCCESS | |
| Testcontainers | [testcontainers (mssql, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555750) | SUCCESS | |
| Testcontainers | [testcontainers (mysql, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555679) | SUCCESS | |
| Testcontainers | [testcontainers (oracle, 15)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555684) | SUCCESS | |
| Testcontainers | [testcontainers (postgres, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555682) | SUCCESS | |
| Testcontainers | [testcontainers (risingwave, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555644) | SUCCESS | |
| Testcontainers | [testcontainers (starrocks, 15)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555685) | SUCCESS | |
| Testcontainers | [testcontainers (timescaledb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555645) | SUCCESS | |
| Testcontainers | [testcontainers (trino, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555726) | SUCCESS | |
| Testcontainers | [testcontainers (ydb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555970) | SUCCESS | |
| Testcontainers | [testcontainers (yugabytedb, 10)](https://github.com/apache/superset/actions/runs/35023417658/job/104564555800) | SUCCESS | |
| Translations | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417640/job/104565097162) | SUCCESS | |
| Translations | [babel-extract](https://github.com/apache/superset/actions/runs/35023417640/job/104564523445) | SUCCESS | |
| Translations | [frontend-check-translations](https://github.com/apache/superset/actions/runs/35023417640/job/104564523770) | SUCCESS | |
| Validate All GitHub Actions | [validate-all-ghas](https://github.com/apache/superset/actions/runs/35023417641/job/104564523695) | SUCCESS | |
| pre-commit checks | [actions-timeline](https://github.com/apache/superset/actions/runs/35023417631/job/104566240204) | SUCCESS | |
| pre-commit checks | [pre-commit (current)](https://github.com/apache/superset/actions/runs/35023417631/job/104564524247) | SUCCESS | Yes |
| πͺ Superset Showtime | [πͺ Sync PR to desired state](https://github.com/apache/superset/actions/runs/35023416405/job/104564521702) | SKIPPED | |
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5688065821
The shared repair #44288 has landed at 4c27cbd007efa298c2c1101b85a1ea158ed0502a. Verified that commit is on master and both the complete migration graph and initialized Alembic ScriptDirectory report exactly one head, e2f3a1b9c640. Rebased this PR without conflicts; git range-diff confirms both PR commits are unchanged in content. Ten focused Pinot tests and pre-commit across all five PR files pass.
Published rebased SHA a56733f76173cf699133c5204c18dfd7a515332c using force-with-lease against exact prior head 48931bcf0423997558f70e795d91da5c2dc92726. Fresh post-repair CI is queued/running and will be monitored through terminal results. No migration workaround, merge, draft conversion or zone movement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #44287:
URL: https://github.com/apache/superset/pull/44287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5785730033
**Bito Automatic Review Skipped β PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5685562011
Live CI audit at head da5e0f6ab2fe65879fdc13af69b65663a6ec5f7f: 73 SUCCESS, 15 FAILURE, 13 conditional SKIPPED, 2 informational Netlify NEUTRAL; no pending/cancelled/action-required checks and no review threads. None of the required checks is skipped. All 15 failures were inspected individually: 12 execution jobs stop at the shared Alembic multiple-head startup error, and 3 required aggregate jobs propagate failure. This is still blocked, not acceptable CI.
Local revalidation: all 10 Pinot unit tests pass (SQLAlchemy 2.0.52 / pinotdb 9.1.2), and pre-commit against all five PR-changed files passes, including mypy, Ruff, pylint and metadata validation. No implementation issue or review feedback requires a code change.
The separate baseline repair #44288 has no failing/pending applicable checks but awaits human review/landing; coordination request: https://github.com/apache/superset/pull/44288#issuecomment-5685535260. I will not merge it or fold its migration into this driver PR. Monitoring for repaired master before rebase, validation, lease-protected push and a fresh complete CI run. Worktree remains in zone-sqlalchemy-2; PR remains open/non-draft and requires human review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5689514063
Independent final-readiness sweep at head `a56733f76173cf699133c5204c18dfd7a515332c` β **all applicable CI is terminal green.**
**Checks:** 86 pass, 12 skipped/neutral, **0 fail, 0 pending, 0 cancelled, 0 action-required.**
**Workflow runs at this exact SHA:** 25 total β 22 `completed/success`, 3 `completed/skipped`. No zero-job failures and no run left in progress.
**Base repair confirmed independently.** #44288 landed as `4c27cbd007`. Recomputing the full migration graph from `origin/master` (`6cfb33197444cbf74590c2803b6dcc06180439f4`) yields 388 revisions and **exactly one head, `e2f3a1b9c640`**. All 15 jobs that previously failed on `Multiple head revisions are present for given argument 'head'` now pass, including the CLI, E2E, integration, Presto/Hive and `docker-build (dev)` jobs. No failure was waived or suppressed.
**Rebase:** already applied cleanly onto the repaired base. Diff re-verified intact β same 5 files, +48/β2, and no `superset/migrations/` files touched by this PR. No further rebase is required: `mergeStateStatus` is `BLOCKED`, not `BEHIND`, so an up-to-date branch is not a merge condition here.
**Review feedback:** 0 review threads and 0 formal reviews (confirmed via GraphQL `reviewThreads.totalCount` / `reviews.totalCount`). Bito re-reviewed the exact rebased range `a31aa6c..a56733f` and reported **0 actionable suggestions**, with MyPy, Astral Ruff, Whispers and Detect-secrets all successful. Nothing outstanding to address.
**Local revalidation on this head:** Pinot unit tests pass (7 passed, 3 skipped); `pinot = ["pinotdb[sqlalchemy]>=8.0.0, <10.0.0"]` intact; worktree clean and local SHA matches the published head exactly.
Dependency claim remains verified directly against PyPI wheel metadata: pinotdb `6.0.0`/`7.0.0` declare `sqlalchemy (>=1.4,<2)` under `extra == "sqlalchemy"`; `8.0.0` is the first release declaring `sqlalchemy (>=2.0,<3)`, unchanged through `9.1.2`.
Standing limitation, restated rather than hidden: `test_dialect_supports_installed_sqlalchemy` uses `pytest.importorskip("pinotdb.sqlalchemy")`, and `pinotdb` is not in `requirements/development.txt`, so that dependency-contract assertion skips rather than executes in `unit-tests (current)`. This matches the existing `tests/unit_tests/db_engine_specs/test_datastore.py` pattern; adding the driver to dev requirements is deliberately out of scope for this PR.
**Only remaining gate is maintainer-only:** `reviewDecision: REVIEW_REQUIRED`. @rusackas is already a requested reviewer.
**Exact human action:** a Superset committer reviews and approves this PR, then merges it. No branch-side code, rebase or CI work remains.
PR remains OPEN, non-draft and mergeable. Nothing merged, nothing converted to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5675822149
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5676110032
The shared master Alembic startup blocker is isolated in ready PR #44288 (`d6f00dcffec9beb74bc9480b40f38515c5527a5a`): a no-op merge of `c7f53d184ea2` and `88a01c781622`, reproduced on master `ae240a8e6f0332acb709943d0884eae73927c9de`.
No driver changes or migration workarounds are added here. Graph/SQLite upgrade-downgrade validation and 147 focused migration tests pass; independent review found no correctness issues. #44288's CI/maintainer review is pending, and its landing must be coordinated with the overlapping ClickHouse migration in #44283. The general Python-Unit jobs on #44285/#44286/#44287 passed; the confirmed blocker is in migration-dependent startup jobs, not that general unit suite. Nothing has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5676021823
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44287?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 75.91%. Comparing base ([`b6de64f`](https://app.codecov.io/gh/apache/superset/commit/b6de64fce749f9d537a32893ef957a70b0b4cb25?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`da5e0f6`](https://app.codecov.io/gh/apache/superset/commit/da5e0f6ab2fe65879fdc13af69b65663a6ec5f7f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44287 +/- ##
==========================================
- Coverage 75.91% 75.91% -0.01%
==========================================
Files 2926 2926
Lines 173023 173023
Branches 40139 40139
==========================================
- Hits 131351 131349 -2
- Misses 38993 38995 +2
Partials 2679 2679
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44287/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/superset/pull/44287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.14% <ΓΈ> (-0.01%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/44287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.14% <ΓΈ> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44287?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5688808039
@rusackas β Amin has assigned you for review. When you have a moment, could you please take a look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5689295167
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pinot): require the SQLAlchemy 2 driver extra [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi commented on PR #44287:
URL: https://github.com/apache/superset/pull/44287#issuecomment-5687210321
Addressed the independent zone audit wording finding in 48931bcf0423997558f70e795d91da5c2dc92726: UPDATING.md, Pinot metadata and generated documentation explicitly state pinotdb[sqlalchemy]>=8.0.0,<10.0.0, including the upper bound. Ten focused Pinot tests and all applicable staged pre-commit hooks passed. Published with an explicit expected-old-SHA lease; worktree is clean. Fresh CI is queued/running and will be inspected. No rebase or migration workaround; post-repair rebase waits for actual #44288 landing on single-head master. No GitHub review threads exist to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org