You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/09/04 15:44:30 UTC
[I] Add complete alert rule portfolio review [rocketmq-dashboard]
yuluo-yx opened a new issue, #3148:
URL: https://github.com/apache/rocketmq-dashboard/issues/3148
### Problem
The alert rule table is paginated and filtered. Operators can duplicate, import, enable, and disable rules, but they cannot review the complete domain inventory for combinations that create duplicate notifications or silently stop coverage. Problems spanning pages are especially difficult to spot.
### Proposed change
Add a read-only portfolio review for both cluster and business alert domains. It should use the existing complete rule-list contract and identify only evidence-backed conditions:
- enabled rules with identical scope and evaluation signatures;
- duplicate rule names;
- enabled rules without notification channels;
- rules referencing instances that no longer exist;
- scopes for which every remaining rule is disabled.
Different thresholds must not be treated as conflicts. The review should provide issue and rule views, filters, CSV export, Chinese/English copy, and focused tests. It must not mutate rules or depend on the current page/filter state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add complete alert rule portfolio review [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #3148:
URL: https://github.com/apache/rocketmq-dashboard/issues/3148#issuecomment-5546422358
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
Thank you for the detailed proposal. This is a well-scoped feature request for a read-only alert rule portfolio review.
**Feasibility:** Feasible — the existing complete rule-list API contract provides the data foundation. The detection rules you listed (duplicate signatures, orphaned instances, missing notification channels, fully-disabled scopes) are all derivable from client-side analysis of the rule inventory without requiring backend changes.
**Scope:** Primarily affects the alert management frontend module. Key implementation areas:
- Data layer: consume the existing full rule-list endpoint, build in-memory indexes for cross-page analysis
- Detection engine: implement the five condition checks (signature dedup, name dedup, missing channels, stale instances, all-disabled scopes)
- UI: new read-only review view with filters, issue/rule perspectives, CSV export, and i18n support
- Tests: focused unit tests for each detection condition
**Compatibility:** No breaking changes — this is additive. Different thresholds are correctly excluded from conflict detection as you specified.
**Notes:**
- The "evidence-backed" constraint (no heuristic conflict detection) is a good design decision that keeps the review actionable
- Cross-page analysis is the core value proposition — worth highlighting in the PR description
- Consider whether "instances that no longer exist" should be checked against the live cluster registry or a cached snapshot
This is a solid enhancement. A PR implementing this would be welcome.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add complete alert rule portfolio review [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3148:
URL: https://github.com/apache/rocketmq-dashboard/issues/3148#issuecomment-6159453003
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add complete alert rule portfolio review [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3148: Add complete alert rule portfolio review
URL: https://github.com/apache/rocketmq-dashboard/issues/3148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org