You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/27 19:24:04 UTC

[GitHub] hughhhh commented on a change in pull request #4871: Add spider/radar chart

hughhhh commented on a change in pull request #4871: Add spider/radar chart 
URL: https://github.com/apache/incubator-superset/pull/4871#discussion_r184784593
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2375,6 +2375,35 @@ def get_data(self, df):
         return result
 
 
+class SpiderRadarViz(BaseViz):
+    """
+    A spider / radar chart.
+    """
+
+    viz_type = 'spider_radar'
+    verbose_name = _('Spider Radar Diagram')
+    credits = (
+        '<a href=https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz Expert</a>')
+    is_timeseries = False
+
+    def get_data(self, df):
 
 Review comment:
   Can we get a some unit test for this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services