You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Dale Thatcher <su...@dalethatcher.com> on 2001/09/14 15:06:56 UTC
Http proxy patch [Was: Re: [Dale Thatcher ] Posting to the list]
Hi,
Thanks for the feedback on the patch. According to ne_auth.h the use of
malloc is required. It's already used in the request_auth function in
session.c and get's freed almost immediately by the neon library.
I'll make the changes so that you can pass in a proxy URI with --http-proxy=
and resubmit the patch. Is the URI format ok?
thanks,
- Dale Thatcher
On Thu, Sep 13, 2001 at 11:21:55PM +0200, Branko Cibej wrote:
> Sander Striker wrote:
>
> >Quick review of the patch:
> >
> >The mallocs have got to go.
> >
> Yes.
>
> And so do the getenvs. Use a comand-line option instead.
>
> -1 (veto) on having Subversion's behaviour depend on environment variables.
>
>
> --
> Brane Cibej <br...@xbc.nu> http://www.xbc.nu/brane/
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Http proxy patch [Was: Re: [Dale Thatcher ] Posting to the list]
Posted by Joe Orton <jo...@manyfish.co.uk>.
On Fri, Sep 14, 2001 at 03:06:56PM +0000, Dale Thatcher wrote:
> Hi,
>
> Thanks for the feedback on the patch. According to ne_auth.h the use of
> malloc is required. It's already used in the request_auth function in
> session.c and get's freed almost immediately by the neon library.
>
> I'll make the changes so that you can pass in a proxy URI with --http-proxy=
> and resubmit the patch. Is the URI format ok?
It's bad practice putting the username+password in the URI. I think
these should be dealt with via the same authentication mechanism as
server auth stuff. Otherwise - looks good, thanks!
joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Http proxy patch [Was: Re: [Dale Thatcher ] Posting to the list]
Posted by Branko Čibej <br...@xbc.nu>.
Dale Thatcher wrote:
>Hi,
>
>Thanks for the feedback on the patch. According to ne_auth.h the use of
>malloc is required. It's already used in the request_auth function in
>session.c and get's freed almost immediately by the neon library.
>
Point. I think this particular malloc (in request_proxy_auth) can stay.
But *please* don't use "l" for variable names. "len" or some such would
be better.
And you should use apr_pstrdup where appropriate, instead of using
apr_pcallod&memcpy. There's also an apr_pstrndup, if you have to extract
a substring.
>I'll make the changes so that you can pass in a proxy URI with --http-proxy=
>and resubmit the patch. Is the URI format ok?
>
Someone else will have to answer that one. Greg? Joe?
--
Brane �ibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org