You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/06/06 21:47:03 UTC
[GitHub] [yunikorn-web] craigcondit opened a new pull request, #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
craigcondit opened a new pull request, #120:
URL: https://github.com/apache/yunikorn-web/pull/120
### What is this PR for?
Fixes the UI glitches that appeared after the Angular 16 update recently.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1788
### How should this be tested?
### Screenshots (if appropriate)
<img width="1699" alt="dashboard" src="https://github.com/apache/yunikorn-web/assets/12699633/736d6e38-f786-4e52-b06f-0de761be420a">
<img width="1702" alt="queues" src="https://github.com/apache/yunikorn-web/assets/12699633/10fa5db7-a41c-4e71-80cd-05152b0fd6a5">
<img width="1706" alt="apps" src="https://github.com/apache/yunikorn-web/assets/12699633/ad2b25c5-1403-4d19-9d13-69d299d57db6">
<img width="1700" alt="nodes" src="https://github.com/apache/yunikorn-web/assets/12699633/ef2f5886-b440-4aeb-9866-343c22d5d4c0">
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] wilfred-s closed pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
URL: https://github.com/apache/yunikorn-web/pull/120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] craigcondit commented on a diff in pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on code in PR #120:
URL: https://github.com/apache/yunikorn-web/pull/120#discussion_r1221705311
##########
src/app/app.component.scss:
##########
@@ -247,6 +247,7 @@ ul.navigation-primary {
.help-menu > .menu-trigger {
background: transparent;
+ font-size: 14px;
Review Comment:
Done
##########
src/app/components/dashboard/dashboard.component.scss:
##########
@@ -61,3 +62,9 @@
flex-direction: column;
padding: 10px;
}
+
+.about-card .info-value {
+ font-size: 16px;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] craigcondit commented on pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #120:
URL: https://github.com/apache/yunikorn-web/pull/120#issuecomment-1580948889
> Angular 15 mentions it in the release notes that a tool has to be run it shows slightly different changes than you have made. I did not link that back to the objects we used while migrating. I found it based on your mdc changes: https://material.angular.io/guide/mdc-migration We need to run that tool as the base change, apply the healthcheck, about-menu, about-card and help-menu changes on top of that.
Good catch. Didn't realize there was an automated tool for this. I've updated the PR, also fixed a minor issue with the search box on the apps page where height was wrong and size was way too large to fit on a reasonable-sized window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] wilfred-s commented on a diff in pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #120:
URL: https://github.com/apache/yunikorn-web/pull/120#discussion_r1220594626
##########
src/app/app.component.scss:
##########
@@ -247,6 +247,7 @@ ul.navigation-primary {
.help-menu > .menu-trigger {
background: transparent;
+ font-size: 14px;
Review Comment:
This should be the same change as in the .info-card > .menu-trigger` of the dashboard so the **?** and **i** use the same formatting.
##########
src/app/components/dashboard/dashboard.component.scss:
##########
@@ -61,3 +62,9 @@
flex-direction: column;
padding: 10px;
}
+
+.about-card .info-value {
+ font-size: 16px;
Review Comment:
nit: decrease the font size to 14px and also add it for the `.about-card` so the description of the value gets same smaller font.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] codecov-commenter commented on pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #120:
URL: https://github.com/apache/yunikorn-web/pull/120#issuecomment-1579501475
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-web/pull/120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#120](https://app.codecov.io/gh/apache/yunikorn-web/pull/120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9f70c63) into [master](https://app.codecov.io/gh/apache/yunikorn-web/commit/0b1cef7ad5a93e5336828bd2d28b29349211c396?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0b1cef7) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-web] wilfred-s commented on a diff in pull request #120: [YUNIKORN-1788] Fix UI styling after Angular 16 update
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #120:
URL: https://github.com/apache/yunikorn-web/pull/120#discussion_r1220594626
##########
src/app/app.component.scss:
##########
@@ -247,6 +247,7 @@ ul.navigation-primary {
.help-menu > .menu-trigger {
background: transparent;
+ font-size: 14px;
Review Comment:
This should be the same change as in the `.info-card > .menu-trigger` of the dashboard so the **?** and **i** use the same formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org