You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/11 01:58:21 UTC
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #80: CI: add test ci
gxthrj opened a new pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540639086
##########
File path: .github/workflows/test-ci.yml
##########
@@ -0,0 +1,23 @@
+name: test-ci
Review comment:
the name test-ci is too generic, actually it's just unit test, we will have e2e tests in the future, so `unit-test.yaml` is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540636611
##########
File path: pkg/ingress/apisix/upstream_test.go
##########
@@ -94,6 +97,7 @@ kind: ApisixUpstream
apiVersion: apisix.apache.org/v1
metadata:
name: httpserver
+ namespace: cloud
Review comment:
This is a test-case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#issuecomment-743086380
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540637121
##########
File path: .github/workflows/test-ci.yml
##########
@@ -0,0 +1,23 @@
+name: test-ci
+
+on:
+ push:
+ branches:
+ - master
+ - kv/ci
+ pull_request:
+ branches:
+ - master
+jobs:
+ run-test:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: setup go
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+ - name: run test
+ working-directory: ./
+ run: |
+ go test ./...
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#issuecomment-743089407
nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540637223
##########
File path: pkg/ingress/apisix/upstream_test.go
##########
@@ -94,6 +97,7 @@ kind: ApisixUpstream
apiVersion: apisix.apache.org/v1
metadata:
name: httpserver
+ namespace: cloud
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540634398
##########
File path: .github/workflows/test-ci.yml
##########
@@ -0,0 +1,23 @@
+name: test-ci
+
+on:
+ push:
+ branches:
+ - master
+ - kv/ci
+ pull_request:
+ branches:
+ - master
+jobs:
+ run-test:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: setup go
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+ - name: run test
+ working-directory: ./
+ run: |
+ go test ./...
Review comment:
Please check the editor, always add the linebreak.
##########
File path: pkg/ingress/apisix/upstream_test.go
##########
@@ -94,6 +97,7 @@ kind: ApisixUpstream
apiVersion: apisix.apache.org/v1
metadata:
name: httpserver
+ namespace: cloud
Review comment:
Still use cloud namespace? we should use ingress-apisix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #80: CI: add test ci
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #80:
URL: https://github.com/apache/apisix-ingress-controller/pull/80#discussion_r540801212
##########
File path: .github/workflows/test-ci.yml
##########
@@ -0,0 +1,23 @@
+name: test-ci
Review comment:
ok, use unit-test-ci.yml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org