You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/01 02:34:04 UTC

[jira] [Commented] (THRIFT-3214) Add Erlang option for using maps instead of dicts

    [ https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609331#comment-14609331 ] 

ASF GitHub Bot commented on THRIFT-3214:
----------------------------------------

GitHub user thecodeboss opened a pull request:

    https://github.com/apache/thrift/pull/535

    THRIFT-3214 Add Erlang option for using maps instead of dicts

    Erlang OTP 18 introduces significant performance improvements when using maps instead of dicts. Here is a benchmark showing the gains:
    
    https://gist.github.com/BinaryMuse/bb9f2cbf692e6cfa4841
    
    Thrift should support an option for the Erlang compiler to produce maps instead of dicts, to take advantage of these performance improvements.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thecodeboss/thrift THRIFT-3214

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #535
    
----
commit 969e1fb45ca6423d2d4353d154f7cb6f861f4bb5
Author: Michael Oliver <mi...@gmail.com>
Date:   2015-07-01T00:22:54Z

    THRIFT-3214 Add Erlang option for using maps instead of dicts

----


> Add Erlang option for using maps instead of dicts
> -------------------------------------------------
>
>                 Key: THRIFT-3214
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3214
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Erlang - Compiler
>            Reporter: Michael Oliver
>            Assignee: Michael Oliver
>            Priority: Minor
>
> Erlang OTP 18 introduces significant performance improvements when using maps instead of dicts. Here is a benchmark showing the gains:
> https://gist.github.com/BinaryMuse/bb9f2cbf692e6cfa4841
> Thrift should support an option for the Erlang compiler to produce maps instead of dicts, to take advantage of these performance improvements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)