Review Request 20909: TAJO-803: INSERT INTO without FROM throws ClassCastException.

[hyoungjun kim <ba...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20909/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-803
    https://issues.apache.org/jira/browse/TAJO-803


Repository: tajo


Description
-------

The following query throws ClassCastException in the TajoMaster.
{noformat}
default> create table temp_table (id int, name text)  using csv with ('csvfile.delimiter'='|');
default> insert overwrite into temp_table select 123::int4 as id, 'abc' as name;
ERROR: org.apache.tajo.engine.planner.logical.EvalExprNode cannot be cast to org.apache.tajo.engine.planner.logical.ProjectionNode
{noformat}

TajoMaster's log
{noformat}
java.lang.ClassCastException: org.apache.tajo.engine.planner.logical.EvalExprNode cannot be cast to org.apache.tajo.engine.planner.logical.ProjectionNode
        at org.apache.tajo.engine.planner.LogicalPlanner.buildProjectedInsert(LogicalPlanner.java:1237)
        at org.apache.tajo.engine.planner.LogicalPlanner.buildInsertIntoTablePlan(LogicalPlanner.java:1224)
        at org.apache.tajo.engine.planner.LogicalPlanner.visitInsert(LogicalPlanner.java:1140)
        at org.apache.tajo.engine.planner.LogicalPlanner.visitInsert(LogicalPlanner.java:58)
        at org.apache.tajo.engine.planner.BaseAlgebraVisitor.visit(BaseAlgebraVisitor.java:123)
        at org.apache.tajo.engine.planner.LogicalPlanner.createPlan(LogicalPlanner.java:121)
        at org.apache.tajo.engine.planner.LogicalPlanner.createPlan(LogicalPlanner.java:108)
        at org.apache.tajo.master.GlobalEngine.createLogicalPlan(GlobalEngine.java:341)
        at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:144)
        at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:260)
        at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:495)
        at org.apache.tajo.rpc.BlockingRpcServer$ServerHandler.messageReceived(BlockingRpcServer.java:103)
        at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70)
        at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
        at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791)
        at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296)
        at org.jboss.netty.handler.codec.oneone.OneToOneDecoder.handleUpstream(OneToOneDecoder.java:70)
{noformat}


Diffs
-----

  tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java 959e9df 
  tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 3c85662 
  tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java 63ac515 
  tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableExec.java 1f927a6 
  tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/StoreTableSingleExec.java PRE-CREATION 
  tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java c87ad84 
  tajo-core/src/main/java/org/apache/tajo/master/querymaster/Query.java 6a5248d 
  tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java 4a14359 
  tajo-core/src/main/java/org/apache/tajo/worker/TaskAttemptContext.java 6f3281c 
  tajo-core/src/test/java/org/apache/tajo/engine/query/TestInsertQuery.java 06ce973 

Diff: https://reviews.apache.org/r/20909/diff/


Testing
-------

mvn clean install;
And tested on local cluster. 


Thanks,

hyoungjun kim