You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/02/19 10:54:57 UTC
[GitHub] [brooklyn] kemitix opened a new pull request #44: Don't install
openjdk
kemitix opened a new pull request #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44
The source image already includes a version of openjdk-8. Removing this command as it fails due to the package not being available from the software repos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] geomacy commented on issue #44: Don't install openjdk
Posted by GitBox <gi...@apache.org>.
geomacy commented on issue #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44#issuecomment-589242354
> Hi Geoff, I believe this is an alternative solution to the problem @tbouron was fixing. Applying both would result in openjdk not being available. Paul
> […](#)
> On Thu, Feb 20, 2020 at 10:15 AM Geoff Macartney ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Dockerfile <[#44 (comment)](https://github.com/apache/brooklyn/pull/44#discussion_r381904448)>: > @@ -19,9 +19,6 @@ # and PhantomJS FROM maven:3.6.3-jdk-8 -# Install the non-headless JRE as some tests requires them your branch is a couple of commits behind master, how will this interact with [667083e](https://github.com/apache/brooklyn/commit/667083e648d52c0aba7f4da600ff17e5510d9b1b) <[667083e](https://github.com/apache/brooklyn/commit/667083e648d52c0aba7f4da600ff17e5510d9b1b)> by @tbouron <https://github.com/tbouron>? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44?email_source=notifications&email_token=AAIYGZM6GNZSNXLPTMSGYM3RDZJ27A5CNFSM4KXWZ3UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWIFKQY#pullrequestreview-361780547>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIYGZLFV447R5U6ZHUZNH3RDZJ27ANCNFSM4KXWZ3UA> .
> -- Paul [W] Campbell
So is this PR needed given that @tbouron's is already there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] geomacy merged pull request #44: Don't install openjdk
Posted by GitBox <gi...@apache.org>.
geomacy merged pull request #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] kemitix commented on issue #44: Don't install openjdk
Posted by GitBox <gi...@apache.org>.
kemitix commented on issue #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44#issuecomment-588926688
Hi Geoff,
I believe this is an alternative solution to the problem @tbouron was
fixing.
Applying both would result in openjdk not being available.
Paul
On Thu, Feb 20, 2020 at 10:15 AM Geoff Macartney <no...@github.com>
wrote:
> *@geomacy* commented on this pull request.
> ------------------------------
>
> In Dockerfile
> <https://github.com/apache/brooklyn/pull/44#discussion_r381904448>:
>
> > @@ -19,9 +19,6 @@
> # and PhantomJS
> FROM maven:3.6.3-jdk-8
>
> -# Install the non-headless JRE as some tests requires them
>
> your branch is a couple of commits behind master, how will this interact
> with 667083e
> <https://github.com/apache/brooklyn/commit/667083e648d52c0aba7f4da600ff17e5510d9b1b>
> by @tbouron <https://github.com/tbouron>?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/brooklyn/pull/44?email_source=notifications&email_token=AAIYGZM6GNZSNXLPTMSGYM3RDZJ27A5CNFSM4KXWZ3UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWIFKQY#pullrequestreview-361780547>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAIYGZLFV447R5U6ZHUZNH3RDZJ27ANCNFSM4KXWZ3UA>
> .
>
--
Paul [W] Campbell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] kemitix commented on issue #44: Don't install openjdk
Posted by GitBox <gi...@apache.org>.
kemitix commented on issue #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44#issuecomment-589262910
@geomacy I think we want to be going forward, and using the updated maven 3.6.3 image, which this PR allows. The PR to roll-back to maven 3.5.4 by @tbouron was added to enable the Jenkins builds to start working again. Now we know what the problem was, this PR removes the need for that version roll-back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] geomacy commented on issue #44: Don't install openjdk
Posted by GitBox <gi...@apache.org>.
geomacy commented on issue #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44#issuecomment-590875879
sounds good to me, merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] geomacy edited a comment on issue #44: Don't install
openjdk
Posted by GitBox <gi...@apache.org>.
geomacy edited a comment on issue #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44#issuecomment-589242354
> Hi Geoff, I believe this is an alternative solution to the problem @tbouron was fixing. Applying both would result in openjdk not being available. Paul
> […](#)
> On Thu, Feb 20, 2020 at 10:15 AM Geoff Macartney ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Dockerfile <[#44 (comment)](https://github.com/apache/brooklyn/pull/44#discussion_r381904448)>: > @@ -19,9 +19,6 @@ # and PhantomJS FROM maven:3.6.3-jdk-8 -# Install the non-headless JRE as some tests requires them your branch is a couple of commits behind master, how will this interact with [667083e](https://github.com/apache/brooklyn/commit/667083e648d52c0aba7f4da600ff17e5510d9b1b) <[667083e](https://github.com/apache/brooklyn/commit/667083e648d52c0aba7f4da600ff17e5510d9b1b)> by @tbouron <https://github.com/tbouron>? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44?email_source=notifications&email_token=AAIYGZM6GNZSNXLPTMSGYM3RDZJ27A5CNFSM4KXWZ3UKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCWIFKQY#pullrequestreview-361780547>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIYGZLFV447R5U6ZHUZNH3RDZJ27ANCNFSM4KXWZ3UA> .
> -- Paul [W] Campbell
So is this PR needed given that @tbouron's is already merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn] geomacy commented on a change in pull request #44: Don't
install openjdk
Posted by GitBox <gi...@apache.org>.
geomacy commented on a change in pull request #44: Don't install openjdk
URL: https://github.com/apache/brooklyn/pull/44#discussion_r381904448
##########
File path: Dockerfile
##########
@@ -19,9 +19,6 @@
# and PhantomJS
FROM maven:3.6.3-jdk-8
-# Install the non-headless JRE as some tests requires them
Review comment:
your branch is a couple of commits behind master, how will this interact with 667083e648d52c0aba7f4da600ff17e5510d9b1b by @tbouron?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services