You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/04/08 00:41:50 UTC

[GitHub] kafka pull request #2829: HOTFIX: Use a true sentinel for `UseDefaultAcls`

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/2829

    HOTFIX: Use a true sentinel for `UseDefaultAcls`

    In 67fc2a91a6, we are using an empty collection and comparing via
    value equality, so if a user passes an empty collection, they will
    get the default ACLs instead of no ACLs. We fix that issue here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka zk-utils-default-acls-improvement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2829
    
----
commit 8122f272855868e288ed02035ba9b6460e77649a
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-04-08T00:38:52Z

    Use a true sentinel instead of an empty collection for `UseDefaultAcls`

commit 2dc84f3159e7adf639f505046a865fc0a2180968
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-04-08T00:39:05Z

    Simplify logic in `sensitivePath`

commit 0846172cd90ba6b6726bc5303e0fe54f1ae05c9a
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-04-08T00:39:28Z

    Add missing import

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2829: HOTFIX: Use a true sentinel for `UseDefaultAcls`

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2829


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---