You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/04 15:43:01 UTC
[GitHub] merlimat commented on a change in pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client
merlimat commented on a change in pull request #1029: Fix MessageRouter hash inconsistent on C++/Java client
URL: https://github.com/apache/incubator-pulsar/pull/1029#discussion_r159682631
##########
File path: pulsar-client-cpp/include/pulsar/ProducerConfiguration.h
##########
@@ -69,6 +69,9 @@ class ProducerConfiguration {
ProducerConfiguration& setMessageRouter(const MessageRoutingPolicyPtr& router);
const MessageRoutingPolicyPtr& getMessageRouterPtr() const;
+ ProducerConfiguration& setUseMurmurHash(const bool useMurmurHash);
Review comment:
I would prefer to have an enum type to select the default hashing scheme (default, since it can always be overridden in a custom message router.
Something like:
```cpp
ProducerConfiguration& setDefaultHashingScheme(HashingScheme hashingScheme);
```
This way it might be interesting to provide the same function across C++ and Java, even the existing functions (eg: `JavaStringHash`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services