You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/02/04 23:03:33 UTC
[GitHub] [hudi] yihua opened a new pull request, #7854: [HUDI-5703] Improve ConfigProperty APIs for docs generation
yihua opened a new pull request, #7854:
URL: https://github.com/apache/hudi/pull/7854
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7854: [HUDI-5703] Improve ConfigProperty APIs for docs generation
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7854:
URL: https://github.com/apache/hudi/pull/7854#issuecomment-1416874456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3257598b8938bd6a2b98f5b105aba75f3e987e3c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3257598b8938bd6a2b98f5b105aba75f3e987e3c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3257598b8938bd6a2b98f5b105aba75f3e987e3c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #7854: [HUDI-5703] Improve ConfigProperty APIs for docs generation
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #7854:
URL: https://github.com/apache/hudi/pull/7854#issuecomment-1416895805
CI is green
<img width="1498" alt="Screen Shot 2023-02-04 at 17 34 45" src="https://user-images.githubusercontent.com/2497195/216797146-87438544-8357-4da1-ab18-c0be9908e1e4.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #7854: [HUDI-5703] Improve ConfigProperty APIs for docs generation
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #7854:
URL: https://github.com/apache/hudi/pull/7854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #7854: [HUDI-5703] Improve ConfigProperty APIs for docs generation
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7854:
URL: https://github.com/apache/hudi/pull/7854#discussion_r1096601100
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -75,14 +73,6 @@
* @see HoodieTableMetaClient
* @since 0.3.0
*/
-@ConfigClassProperty(name = "Table Configurations",
Review Comment:
Removing annotation for `HoodieTableConfig` so they do not show up on the configuration page, as these are not meant to be changed by the user.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##########
@@ -59,10 +59,11 @@
* Indexing related config.
*/
@Immutable
-@ConfigClassProperty(name = "Index Configs",
+@ConfigClassProperty(name = "Common Index Configs",
groupName = ConfigGroups.Names.WRITE_CLIENT,
- description = "Configurations that control indexing behavior, "
- + "which tags incoming records as either inserts or updates to older records.")
+ subGroupName = ConfigGroups.SubGroupNames.INDEX,
+ areCommonConfigs = true,
+ description = "")
Review Comment:
Note that the description of common configs under a subgroup is moved to `ConfigGroups.SubGroupNames` enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org