You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/07 05:46:46 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #28129:
[SPARK-31346][SQL]Add new configuration to make sure temporary directory
cleaned
cloud-fan commented on a change in pull request #28129: [SPARK-31346][SQL]Add new configuration to make sure temporary directory cleaned
URL: https://github.com/apache/spark/pull/28129#discussion_r404549412
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
##########
@@ -140,7 +141,9 @@ private[hive] trait SaveAsHiveFile extends DataWritingCommand {
try {
createdTempDir.foreach { path =>
val fs = path.getFileSystem(hadoopConf)
- if (fs.delete(path, true)) {
+ // Sometimes (e.g., when speculative task is enabled), temporary directories may be
+ // left uncleaned, confirmTempDirDeleted can confirm deleteOnExit.
Review comment:
Do you mean even if we delete the temp dir here, some tasks may re-create it later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org