You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/06/23 15:49:54 UTC
[GitHub] [rocketmq] zplovekq opened a new pull request #3053: [ISSUE #3048]Dev simple code for schedule msg and send-one-way producer
zplovekq opened a new pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-866971443
[](https://coveralls.io/builds/40936712)
Coverage increased (+0.06%) to 54.141% when pulling **81ae5434a75a0fda8dcc04dd4b150faa5dd7255e on zplovekq:dev_simple_code** into **160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-892349044
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3053](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4cde2e) into [develop](https://codecov.io/gh/apache/rocketmq/commit/df1d93fc8859377b92ba87c6947911281656f355?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df1d93f) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #3053 +/- ##
=============================================
- Coverage 47.97% 47.87% -0.11%
+ Complexity 4570 4551 -19
=============================================
Files 552 552
Lines 36628 36521 -107
Branches 4844 4818 -26
=============================================
- Hits 17573 17485 -88
+ Misses 16832 16818 -14
+ Partials 2223 2218 -5
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../broker/subscription/SubscriptionGroupManager.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc3Vic2NyaXB0aW9uL1N1YnNjcmlwdGlvbkdyb3VwTWFuYWdlci5qYXZh) | `54.11% <0.00%> (-16.48%)` | :arrow_down: |
| [...rg/apache/rocketmq/common/stats/StatsSnapshot.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNTbmFwc2hvdC5qYXZh) | `84.61% <0.00%> (-15.39%)` | :arrow_down: |
| [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-13.05%)` | :arrow_down: |
| [...org/apache/rocketmq/store/ha/WaitNotifyObject.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL1dhaXROb3RpZnlPYmplY3QuamF2YQ==) | `66.07% <0.00%> (-12.78%)` | :arrow_down: |
| [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: |
| [.../apache/rocketmq/common/stats/MomentStatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtLmphdmE=) | `38.09% <0.00%> (-9.53%)` | :arrow_down: |
| [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: |
| [...a/org/apache/rocketmq/logging/inner/SysLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9TeXNMb2dnZXIuamF2YQ==) | `28.57% <0.00%> (-5.72%)` | :arrow_down: |
| [...va/org/apache/rocketmq/common/stats/StatsItem.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtLmphdmE=) | `50.00% <0.00%> (-5.00%)` | :arrow_down: |
| [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `41.79% <0.00%> (-4.48%)` | :arrow_down: |
| ... and [47 more](https://codecov.io/gh/apache/rocketmq/pull/3053/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df1d93f...c4cde2e](https://codecov.io/gh/apache/rocketmq/pull/3053?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-892282337
@zplovekq waiting for your fix to make the CI. passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zplovekq commented on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
zplovekq commented on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-892327481
> @zplovekq waiting for your fix to make the CI. passed
thanks! i am fixing it !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zplovekq closed pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
zplovekq closed pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-866971443
[](https://coveralls.io/builds/41886609)
Coverage increased (+0.07%) to 54.152% when pulling **c4cde2ec7956277acbe8652d698d5cf24a80573d on zplovekq:dev_simple_code** into **160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zplovekq closed pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
zplovekq closed pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-866971443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-866971443
[](https://coveralls.io/builds/41885980)
Coverage increased (+0.07%) to 54.152% when pulling **198e8cb64bbf8b443c205d28927e3d325ab2625b on zplovekq:dev_simple_code** into **160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zplovekq commented on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
zplovekq commented on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-892340665
> @zplovekq waiting for your fix to make the CI. passed
I find the CI is not passed because of the maven_code_style_plugin. I have fixed these problems by idea checkstyle plugin with style/rmq_checkstyle.xml. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3053: [ISSUE #3048]Dev simple code for schedule msg and send-one-way producer
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-866971443
[](https://coveralls.io/builds/40820894)
Coverage increased (+0.05%) to 54.131% when pulling **349f838c85053b7fd35d4ad64c553ca0045c1743 on zplovekq:dev_simple_code** into **160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3053: [ISSUES #3048]add example of OnewayProducer and ScheduledMessage
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3053:
URL: https://github.com/apache/rocketmq/pull/3053#issuecomment-866971443
[](https://coveralls.io/builds/40936339)
Coverage decreased (-0.003%) to 54.076% when pulling **81ae5434a75a0fda8dcc04dd4b150faa5dd7255e on zplovekq:dev_simple_code** into **160c5772fbdf02e55cdc67bc3b74bb9f9c4c644b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org